Optimising

Author: ivahaev

client.go

@@ -8,7 +8,7 @@ import (
 )
 
 func (c *Conn) receiveWelcome() error {
-	var data string
+	var data []byte
 	err := websocket.Message.Receive(c.connection, &data)
 	if err != nil {
 		return errors.Wrap(err, "Can't receive welcome message")

parser.go

@@ -6,9 +6,9 @@ import (
 	"github.com/pkg/errors"
 )
 
-func parseMessage(_msg string) (int, []interface{}, error) {
+func parseMessage(_msg []byte) (int, []interface{}, error) {
 	var msg []interface{}
-	err := json.Unmarshal([]byte(_msg), &msg)
+	err := json.Unmarshal(_msg, &msg)
 	if err != nil {
 		return 0, nil, errors.Wrap(err, "when unmarshaling wamp message")
 	}

parser_test.go

@@ -2,10 +2,10 @@ package wango
 
 import "testing"
 
-var validMessage = `["CALL","0f2ac8b4-0d18-c6a0-acf1-a338f53a7f2e","com.state"]`
-var invalidRPCMessage = `[2,"0f2ac8b4-0d18-c6a0-acf1-a338f53a7f2e"]`
-var invalidMessage = `["CALL","0f2ac8b4-0d18-c6a0-acf1-a338f53a7f2e","com.state"`
-var validSubMessage = `[5,"com.uri", 6]`
+var validMessage = []byte(`["CALL","0f2ac8b4-0d18-c6a0-acf1-a338f53a7f2e","com.state"]`)
+var invalidRPCMessage = []byte(`[2,"0f2ac8b4-0d18-c6a0-acf1-a338f53a7f2e"]`)
+var invalidMessage = []byte(`["CALL","0f2ac8b4-0d18-c6a0-acf1-a338f53a7f2e","com.state"`)
+var validSubMessage = []byte(`[5,"com.uri", 6]`)
 
 func TestParseValidMessage(t *testing.T) {
 	callType, msg, err := parseMessage(validMessage)

wamp.go

@@ -357,9 +357,9 @@ func (w *Wango) receive(c *Conn) {
 		c.connection.Close()
 		w.deleteConnection(c)
 	}()
-	dataChan := make(chan string)
+	dataChan := make(chan []byte)
 	go func() {
-		var data string
+		var data []byte
 		for {
 			err := websocket.Message.Receive(c.connection, &data)
 			if err != nil {
@@ -646,9 +646,9 @@ func (w *Wango) handleUnSubscribe(c *Conn, msg []interface{}) {
 	go c.send(response)
 }
 
-func (w *Wango) handleHeartbeat(c *Conn, msg []interface{}, data string) {
+func (w *Wango) handleHeartbeat(c *Conn, msg []interface{}, data []byte) {
 	if !c.clientConnection {
-		c.send([]byte(data))
+		c.send(data)
 	}
 }