buildpacks_test.go

package api_test

import (
	"net/http"
	"net/http/httptest"
	"time"

	. "code.cloudfoundry.org/cli/cf/api"
	"code.cloudfoundry.org/cli/cf/api/apifakes"
	"code.cloudfoundry.org/cli/cf/configuration/coreconfig"
	"code.cloudfoundry.org/cli/cf/errors"
	"code.cloudfoundry.org/cli/cf/models"
	"code.cloudfoundry.org/cli/cf/net"
	"code.cloudfoundry.org/cli/cf/terminal/terminalfakes"
	"code.cloudfoundry.org/cli/cf/trace/tracefakes"
	testconfig "code.cloudfoundry.org/cli/cf/util/testhelpers/configuration"
	. "code.cloudfoundry.org/cli/cf/util/testhelpers/matchers"
	testnet "code.cloudfoundry.org/cli/cf/util/testhelpers/net"
	. "github.com/onsi/ginkgo"
	. "github.com/onsi/gomega"
)

var _ = Describe("Buildpacks repo", func() {
	var (
		ts      *httptest.Server
		handler *testnet.TestHandler
		config  coreconfig.ReadWriter
		repo    BuildpackRepository
	)

	BeforeEach(func() {
		config = testconfig.NewRepositoryWithDefaults()
		gateway := net.NewCloudControllerGateway(config, time.Now, new(terminalfakes.FakeUI), new(tracefakes.FakePrinter), "")
		repo = NewCloudControllerBuildpackRepository(config, gateway)
	})

	AfterEach(func() {
		ts.Close()
	})

	var setupTestServer = func(requests ...testnet.TestRequest) {
		ts, handler = testnet.NewServer(requests)
		config.SetAPIEndpoint(ts.URL)
	}

	It("lists buildpacks", func() {
		setupTestServer(
			apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body: `{
					  "next_url": "/v2/buildpacks?page=2",
					  "resources": [
						{
						  "metadata": {
							"guid": "buildpack1-guid"
						  },
						  "entity": {
							"name": "Buildpack1",
							"position" : 1,
							"filename" : "firstbp.zip"
						  }
						}
					  ]
					}`}}),
			apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks?page=2",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body: `{
					  "resources": [
						{
						  "metadata": {
							"guid": "buildpack2-guid"
						  },
						  "entity": {
							"name": "Buildpack2",
							"position" : 2
						  }
						}
					  ]
					}`},
			}))

		buildpacks := []models.Buildpack{}
		err := repo.ListBuildpacks(func(b models.Buildpack) bool {
			buildpacks = append(buildpacks, b)
			return true
		})

		one := 1
		two := 2
		Expect(buildpacks).To(ConsistOf([]models.Buildpack{
			{
				GUID:     "buildpack1-guid",
				Name:     "Buildpack1",
				Position: &one,
				Filename: "firstbp.zip",
			},
			{
				GUID:     "buildpack2-guid",
				Name:     "Buildpack2",
				Position: &two,
			},
		}))
		Expect(handler).To(HaveAllRequestsCalled())
		Expect(err).NotTo(HaveOccurred())
	})

	Describe("finding buildpacks by name", func() {
		It("returns the buildpack with that name", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks?q=name%3ABuildpack1",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body: `{"resources": [
					  {
						  "metadata": {
							  "guid": "buildpack1-guid"
						  },
						  "entity": {
							  "name": "Buildpack1",
							  "position": 10
						  }
					  }
					  ]
				  }`}}))

			buildpack, apiErr := repo.FindByName("Buildpack1")

			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr).NotTo(HaveOccurred())

			Expect(buildpack.Name).To(Equal("Buildpack1"))
			Expect(buildpack.GUID).To(Equal("buildpack1-guid"))
			Expect(*buildpack.Position).To(Equal(10))
		})

		It("returns a ModelNotFoundError when the buildpack is not found", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks?q=name%3ABuildpack1",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body:   `{"resources": []}`,
				},
			}))

			_, apiErr := repo.FindByName("Buildpack1")
			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr.(*errors.ModelNotFoundError)).NotTo(BeNil())
		})

		It("returns a AmbiguousModelError when more than one buildpack with the same name exists", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks?q=name%3ABuildpack1",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body: `{"resources": [
					  {
						  "metadata": {
							  "guid": "buildpack1-guid"
						  },
						  "entity": {
							  "name": "Buildpack1",
								"stack": "Stack1",
							  "position": 10
						  }
					  },
					  {
						  "metadata": {
							  "guid": "buildpack1-guid2"
						  },
						  "entity": {
							  "name": "Buildpack1",
								"stack": "Stack2",
							  "position": 11
						  }
					  }
					  ]
				  }`},
			}))

			_, apiErr := repo.FindByName("Buildpack1")
			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr).To(BeAssignableToTypeOf(&errors.AmbiguousModelError{}))
		})
	})

	Describe("finding buildpacks by name and stack", func() {
		It("returns the buildpack with that name and stack", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks?q=name%3ABuildpack1%3Bstack%3AStack1",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body: `{"resources": [
					  {
						  "metadata": {
							  "guid": "buildpack1-guid"
						  },
						  "entity": {
							  "name": "Buildpack1",
								"stack": "Stack1",
							  "position": 10
						  }
					  }
					  ]
				  }`}}))

			buildpack, apiErr := repo.FindByNameAndStack("Buildpack1", "Stack1")

			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr).NotTo(HaveOccurred())

			Expect(buildpack.Name).To(Equal("Buildpack1"))
			Expect(buildpack.Stack).To(Equal("Stack1"))
			Expect(buildpack.GUID).To(Equal("buildpack1-guid"))
			Expect(*buildpack.Position).To(Equal(10))
		})

		It("returns a ModelNotFoundError when the buildpack is not found", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method: "GET",
				Path:   "/v2/buildpacks?q=name%3ABuildpack1%3Bstack%3AStack1",
				Response: testnet.TestResponse{
					Status: http.StatusOK,
					Body:   `{"resources": []}`,
				},
			}))

			_, apiErr := repo.FindByNameAndStack("Buildpack1", "Stack1")
			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr.(*errors.ModelNotFoundError)).NotTo(BeNil())
		})
	})

	Describe("creating buildpacks", func() {
		It("returns an error when the buildpack has an invalid name", func() {
			setupTestServer(testnet.TestRequest{
				Method: "POST",
				Path:   "/v2/buildpacks",
				Response: testnet.TestResponse{
					Status: http.StatusBadRequest,
					Body: `{
					"code":290003,
					"description":"Buildpack is invalid: [\"name can only contain alphanumeric characters\"]",
					"error_code":"CF-BuildpackInvalid"
				}`,
				}})

			one := 1
			createdBuildpack, apiErr := repo.Create("name with space", &one, nil, nil)
			Expect(apiErr).To(HaveOccurred())
			Expect(createdBuildpack).To(Equal(models.Buildpack{}))
			Expect(apiErr.(errors.HTTPError).ErrorCode()).To(Equal("290003"))
			Expect(apiErr.Error()).To(ContainSubstring("Buildpack is invalid"))
		})

		It("sets the position flag when creating a buildpack", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method:  "POST",
				Path:    "/v2/buildpacks",
				Matcher: testnet.RequestBodyMatcher(`{"name":"my-cool-buildpack","position":999}`),
				Response: testnet.TestResponse{
					Status: http.StatusCreated,
					Body: `{
					"metadata": {
						"guid": "my-cool-buildpack-guid"
					},
					"entity": {
						"name": "my-cool-buildpack",
						"position":999
					}
				}`},
			}))

			position := 999
			created, apiErr := repo.Create("my-cool-buildpack", &position, nil, nil)

			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr).NotTo(HaveOccurred())

			Expect(created.GUID).NotTo(BeNil())
			Expect("my-cool-buildpack").To(Equal(created.Name))
			Expect(999).To(Equal(*created.Position))
		})

		It("sets the enabled flag when creating a buildpack", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method:  "POST",
				Path:    "/v2/buildpacks",
				Matcher: testnet.RequestBodyMatcher(`{"name":"my-cool-buildpack","position":999, "enabled":true}`),
				Response: testnet.TestResponse{
					Status: http.StatusCreated,
					Body: `{
					"metadata": {
						"guid": "my-cool-buildpack-guid"
					},
					"entity": {
						"name": "my-cool-buildpack",
						"position":999,
						"enabled":true
					}
				}`},
			}))

			position := 999
			enabled := true
			created, apiErr := repo.Create("my-cool-buildpack", &position, &enabled, nil)

			Expect(handler).To(HaveAllRequestsCalled())
			Expect(apiErr).NotTo(HaveOccurred())

			Expect(created.GUID).NotTo(BeNil())
			Expect(created.Name).To(Equal("my-cool-buildpack"))
			Expect(999).To(Equal(*created.Position))
		})
	})

	It("deletes buildpacks", func() {
		setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
			Method: "DELETE",
			Path:   "/v2/buildpacks/my-cool-buildpack-guid",
			Response: testnet.TestResponse{
				Status: http.StatusNoContent,
			}}))

		err := repo.Delete("my-cool-buildpack-guid")

		Expect(handler).To(HaveAllRequestsCalled())
		Expect(err).NotTo(HaveOccurred())
	})

	Describe("updating buildpacks", func() {
		It("updates a buildpack's name, position and enabled flag", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method:  "PUT",
				Path:    "/v2/buildpacks/my-cool-buildpack-guid",
				Matcher: testnet.RequestBodyMatcher(`{"name":"my-cool-buildpack","position":555,"enabled":false}`),
				Response: testnet.TestResponse{
					Status: http.StatusCreated,
					Body: `{
						"metadata": {
							"guid": "my-cool-buildpack-guid"
						},
						"entity": {
							"name": "my-cool-buildpack",
							"position":555,
							"enabled":false
						}
					}`},
			}))

			position := 555
			enabled := false
			buildpack := models.Buildpack{
				Name:     "my-cool-buildpack",
				GUID:     "my-cool-buildpack-guid",
				Position: &position,
				Enabled:  &enabled,
			}

			updated, err := repo.Update(buildpack)

			Expect(handler).To(HaveAllRequestsCalled())
			Expect(err).NotTo(HaveOccurred())
			Expect(updated).To(Equal(buildpack))
		})

		It("sets the locked attribute on the buildpack", func() {
			setupTestServer(apifakes.NewCloudControllerTestRequest(testnet.TestRequest{
				Method:  "PUT",
				Path:    "/v2/buildpacks/my-cool-buildpack-guid",
				Matcher: testnet.RequestBodyMatcher(`{"name":"my-cool-buildpack","locked":true}`),
				Response: testnet.TestResponse{
					Status: http.StatusCreated,
					Body: `{

						"metadata": {
							"guid": "my-cool-buildpack-guid"
						},
						"entity": {
							"name": "my-cool-buildpack",
							"position":123,
							"locked": true
						}
					}`},
			}))

			locked := true

			buildpack := models.Buildpack{
				Name:   "my-cool-buildpack",
				GUID:   "my-cool-buildpack-guid",
				Locked: &locked,
			}

			updated, err := repo.Update(buildpack)

			Expect(handler).To(HaveAllRequestsCalled())
			Expect(err).NotTo(HaveOccurred())

			position := 123
			Expect(updated).To(Equal(models.Buildpack{
				Name:     "my-cool-buildpack",
				GUID:     "my-cool-buildpack-guid",
				Position: &position,
				Locked:   &locked,
			}))
		})
	})
})