Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change auto-update to optional, default to null #4433

Closed
mitchellh opened this issue Jan 2, 2025 · 0 comments · Fixed by #4436
Closed

Change auto-update to optional, default to null #4433

mitchellh opened this issue Jan 2, 2025 · 0 comments · Fixed by #4436
Assignees
Labels
Milestone

Comments

@mitchellh
Copy link
Contributor

Change the auto-update config1 to an optional ?AutoUpdate and default it to "null".

The behavior when "null" (unset) is that we defer to the Sparkle default behavior. This will allow users to override this using standard defaults. I think this will also incidentally change it so that on first run Sparkle asks the user for permission to check for updates instead of us pinging right away (which should alleviate some users privacy concerns although we don't track that data).

This will also make it so the checkbox during update dialogs work.

Footnotes

  1. https://ghostty.org/docs/config/reference#auto-update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants