You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation of GitLabApiClient does not provide a simple and easy way to configure/customize HTTP client.
So to fix this problem, we need to make the HTTP client pluggable.
To do this we need to:
Make HTTP client implementation pluggable during GitLabApi creation
Extract public contract of GitLabApiClient to separate interface.
Provide interface implementation with other clients (at least okhttp)
Now we depend on implementation of javax.ws.rs.client.Client interface, so we can provide the implementation of this interface with OkHttp client (not sure here, maybe the better solution is to remove dependency on the Client interface and add a custom one)
@jabby Do we have any concerns about these changes?
The text was updated successfully, but these errors were encountered:
The current implementation of GitLabApiClient does not provide a simple and easy way to configure/customize HTTP client.
So to fix this problem, we need to make the HTTP client pluggable.
To do this we need to:
Now we depend on implementation of javax.ws.rs.client.Client interface, so we can provide the implementation of this interface with OkHttp client (not sure here, maybe the better solution is to remove dependency on the Client interface and add a custom one)
@jabby Do we have any concerns about these changes?
The text was updated successfully, but these errors were encountered: