Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: is it expected to see also system wide files to be "sent"? #34

Open
yarikoptic opened this issue Oct 27, 2020 · 2 comments
Open

Q: is it expected to see also system wide files to be "sent"? #34

yarikoptic opened this issue Oct 27, 2020 · 2 comments

Comments

@yarikoptic
Copy link

after some hand-twisting of datalad to not blow up due to nested async loop (just temp workaround) etc, I managed to get pycrunch to discover some tests and I tried to run but then saw log being populated with "sending" of system wide paths somewhere -- is that expected? (in general I do not care to monitor code outside of the project)

[1087866] 2020-10-27 14:01:57,749 - pycrunch.pipeline.download_file_task - DEBUG - sending file /usr/lib/python3/dist-packages/iso8601/__init__.py
[1087866] 2020-10-27 14:01:57,752 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,757 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,759 - pycrunch.pipeline.download_file_task - DEBUG - sending file /home/yoh/proj/datalad/datalad-master/datalad/support/network.py
[1087866] 2020-10-27 14:01:57,765 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,781 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,784 - pycrunch.pipeline.download_file_task - DEBUG - sending file /home/yoh/proj/datalad/datalad-master/datalad/support/keyring_.py
[1087866] 2020-10-27 14:01:57,788 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,791 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,792 - pycrunch.pipeline.download_file_task - DEBUG - sending file /usr/lib/python3/dist-packages/vcr/filters.py
[1087866] 2020-10-27 14:01:57,796 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,799 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,800 - pycrunch.pipeline.download_file_task - DEBUG - sending file /usr/lib/python3/dist-packages/vcr/serializers/jsonserializer.py
[1087866] 2020-10-27 14:01:57,803 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,817 - pycrunch.pipeline.execution_pipeline - DEBUG - Received task in queue
[1087866] 2020-10-27 14:01:57,820 - pycrunch.pipeline.download_file_task - DEBUG - sending file /usr/lib/python3/dist-packages/vcr/_handle_coroutine.py
@gleb-britecore
Copy link
Collaborator

I think this behavior should be disabled by default, so it will be more secure, and no one on the network can attach to WebSocket and read files

That is only for WebUI, so it can render coverage on actual file. I do not use WebUI anymore and this probably should be handled as part of #33
by providing --unsafe flag or similar

actual call is made js side:
https://github.com/gleb-sevruk/pycrunch-engine/blob/master/front/src/store.js#L17

But PyCharm extension does not need this at all.

@gleb-britecore
Copy link
Collaborator

The above comment doesn't answer original question, see here: #31 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants