Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number rounding still have problems with inaccurate floating point arithmetic #884

Closed
DokaRus opened this issue Jan 10, 2020 · 1 comment
Closed

Number rounding still have problems with inaccurate floating point arithmetic #884

DokaRus opened this issue Jan 10, 2020 · 1 comment

Comments

@DokaRus
Copy link

DokaRus commented Jan 10, 2020

@rxaviers looks like #386 only solves the problem for positive numbers.

Globalizejs v.1.4.2
image

Related issues or PRs: #386 #856
@DokaRus DokaRus mentioned this issue Jan 10, 2020
Merged
@rxaviers
Copy link
Member

The problem fixed by #386 is related to inaccurate floating point arithmetics, which doesn't happen here. The results posted here are correct. Note you can change the rounding mode if needed via options.round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rxaviers @DokaRus