Skip to content
This repository has been archived by the owner on May 24, 2020. It is now read-only.

Add cluster monitoring to the monitoring stack #88

Open
sidharthanup opened this issue Dec 19, 2018 · 3 comments
Open

Add cluster monitoring to the monitoring stack #88

sidharthanup opened this issue Dec 19, 2018 · 3 comments

Comments

@sidharthanup
Copy link
Contributor

The monitoring stack in GCS currently only gives us metrics obtained from the gluster-exporter. It should also pick up node level metrics and cluster level metrics that can be obtained from node-exporter and kube-state-metrics exporter respectively. Also it should report metrics on the prometheus operator also as the operator by default exposes metrics that can be scraped by the deployed prometheus server.

@sidharthanup
Copy link
Contributor Author

sidharthanup commented Dec 19, 2018

In the PR, I have removed the monitoring namespace and relocated the monitoring objects in the gcs namespace itself. Is a separate namespace for monitoring necessary? Functionality wise there is no issues in having it in gcs namespace only. Architecturally is there any advantage in having a separate monitoring namespace where the monitoring stack resides?
@JohnStrunk @Madhu-1 Your thoughts?
Will revert back to previous model if it is an issue.

@JohnStrunk
Copy link
Member

If the components are "things we would deploy as a part of gcs" (i.e., they would be deployed if and only if GCS is deployed), they should be in the gcs namespace.

If there are components that we are deploying because we need to make use of them, but any reasonable cluster would be providing that for us, it should probably go elsewhere. (example: etcd-operator would be provided by OLM... we should move it).

My rationale here is that a namespace is the way of grouping things, and it has a security boundary. When deployed in production, the RBAC rules will limit us to our own namespace (unless we have a really good reason). Also, cleaning up our components is just: kubectl delete ns/gcs

@sidharthanup
Copy link
Contributor Author

Ack. The prometheus operator would be provided by OLM as well(For now I'm putting it in the gcs namespace) . The rest of the components can be in the same namespace itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants