Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collection reference when switching profiles #159

Open
glutanimate opened this issue May 23, 2022 · 1 comment
Open

Update collection reference when switching profiles #159

glutanimate opened this issue May 23, 2022 · 1 comment
Assignees
@glutanimate
Labels
bug Something isn't working regression Regression from an earlier release
Milestone
v1.0.2

Comments

@glutanimate
Copy link
Owner

Due to an oversight between HeatmapController and ActivityReporter, we currently do not properly reconnect to the new collection when switching profiles. We should either drop storing a reference to the collection in the first place, always accessing it via mw.col, or subscribe to a profile switch hook and update the reference.

Split off from #153
@glutanimate glutanimate added bug Something isn't working regression Regression from an earlier release labels May 23, 2022
@glutanimate glutanimate self-assigned this May 23, 2022
@glutanimate glutanimate changed the title Handle profile switching properly Update collection reference when switching profiles May 23, 2022
@glutanimate glutanimate added this to the v1.0.2 milestone May 23, 2022
This was referenced May 23, 2022
Closed
Closed
@glutanimate
Copy link
Owner Author

Potentially related: #177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glutanimate glutanimate

Labels
bug Something isn't working regression Regression from an earlier release
Projects
None yet
Milestone
v1.0.2
Development

No branches or pull requests
1 participant
@glutanimate