Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/gno): only perform preprocessing in lint #3597

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Jan 23, 2025

fixes #3547

cc @leohhhn

Verified

This commit was signed with the committer’s verified signature.
thehowl Morgan
@thehowl thehowl requested a review from gfanton January 23, 2025 18:45
@thehowl thehowl self-assigned this Jan 23, 2025
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Jan 23, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 23, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Sorry, something went wrong.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 91.17647% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/test/imports.go 78.94% 3 Missing and 1 partial ⚠️
gnovm/pkg/gnolang/machine.go 94.59% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Verified

This commit was signed with the committer’s verified signature.
thehowl Morgan

Verified

This commit was signed with the committer’s verified signature.
thehowl Morgan

Verified

This commit was signed with the committer’s verified signature.
thehowl Morgan
…fixes
@leohhhn
Copy link
Contributor

leohhhn commented Feb 6, 2025

Tested locally, works for the case in #3523

Maybe add a small txtar?

Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
thehowl Morgan
@thehowl thehowl merged commit 7e1f5b5 into gnolang:master Feb 6, 2025
65 checks passed
@thehowl thehowl deleted the dev/morgan/lint-fixes branch February 6, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

gno lint actually executes code
4 participants