Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove input deadline #126

Open
auryn-macmillan opened this issue Oct 1, 2024 · 0 comments
Open

Remove input deadline #126

auryn-macmillan opened this issue Oct 1, 2024 · 0 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request evm Related to the EVM package

Comments

@auryn-macmillan
Copy link
Member

IE3 currently has a concept of duration and expiration.

The comments describe duration and expiration as defining the life-time of the E3 along with the timestamp at which committee duties expire, presumably after this timestamp committee members are no longer required to respond to decryption requests as they should have disposed of the keys for this E3.

/// @param duration Duration of the E3.
/// @param expiration Timestamp when committee duties expire.

However, in Enclave.sol we treat expiration as a deadline by which inputs must be published and require that this timestamp passed before the output can be published.

At the very least, we should make the natspec comments consistent with the use. However, I'd like to propose that we remove the concept of an input deadline from Enclave.sol and rely on implementations of IInputValidator.sol to define their own logic around input timing and implementations of IE3Program.sol to define their own logic for if/when/how ciphertext outputs should be published.

@auryn-macmillan auryn-macmillan added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request evm Related to the EVM package labels Oct 1, 2024
@auryn-macmillan auryn-macmillan self-assigned this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request evm Related to the EVM package
Projects
None yet
Development

No branches or pull requests

1 participant