Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

Suggest NetDialTimeout be part of Dialer NOT Global #40

Open
krolaw opened this issue Dec 13, 2018 · 2 comments
Open

Suggest NetDialTimeout be part of Dialer NOT Global #40

krolaw opened this issue Dec 13, 2018 · 2 comments

Comments

@krolaw
Copy link

krolaw commented Dec 13, 2018

For systems like Google's app engine (standard), out going sockets need a context (per incoming http connection). see: https://godoc.org/google.golang.org/appengine/socket
This makes it really hard when the netDialout command is global, since simultaneous requests are coming in. It's much more practical than before though.

@ivy
Copy link

ivy commented Jan 9, 2019

@krolaw Agreed. I would accept a pull request adding a NetDialTimeout field to Dialer and using the global NetDialTimeout as a fallback.

Edit: I see you've already done this in PR #41. I'll review and see if we can get this merged. 😄

@krolaw
Copy link
Author

krolaw commented May 31, 2019

Hi, any movement on this? Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants