-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1a9] Target color setting very slow to update #46
Comments
well it needs to calculate live the targets the first time you touch the slide, but it should take 20 to 50ms depending on the number of Targets you have. 10+ seconds that's kinda crazy. can you take a video and show me what it targets? thanks. |
here's how it works here: ScreenFlow.mp4 |
if you move the slider fast at first there's a slight delay because it's grabbing the Targets. but definitely shouldn't be 10+ seconds 😂️ i'm experimenting with loading the Targets only once when you enter the Tab, but this causes other issues. like if you move the Settings window, all the Targets will be out of place. this is currently the best balance i've found. |
tried both on Ventura public beta 2, and Monterey 12.5. all good. so please:
thanks. |
Wooshy_1a9_Prefs_Looks_Target-color.mov |
full screen, thanks. i need to see what Wooshy is targeting.
can you do that and let me know if it helps? thanks. else i can't follow up on this issue. |
@archetyped still the case? |
Yes, Wooshy 1a18 hangs for about 7 seconds after the Color setting is changed. Interestingly, there is no hanging or delay when the The video below was recorded after rebooting the computer and restarting the app: Wooshy_1a18_Prefs_Looks_Target-color.mp4 |
yeah the |
this is the result here, which is what is expected: ScreenFlow.mp4it's just running Wooshy against the current will try on Monterey again, but i think i did before and it was fine. |
interesting. i was able to reproduce it once under Monterey, after two minutes trying: ScreenFlow.mp4not sure if it's related to your case as it seems in your case it's happening all the time. but i'll have a look. |
Just in case it helps narrow down the issue, I noted the responsiveness was different between
No slowdown when activating Wooshy in normal use, in any of the color modes.
Yes, the hanging is consistently occurring. |
I systematically closed out the apps that displayed menu bar icons to see if that had any effect. There were two apps that had an effect on Wooshy hanging when changing the color mode: If either app displayed an icon in the menu bar, Wooshy would hang when changing the color mode. Note: Even hiding the icons using a menu bar cleanup app (I'm using Hidden Bar) prevented Wooshy from hanging when changing the color mode. Unfortunately, hiding PhraseExpress' menu bar icon affects its functionality (its popup menu is normally displayed at the icon's location, but not when it is hidden). |
yeah, coz i've changed the way the hue works. because you need constant update when playing with the slider, the stuff happens on a background thread. but not for the other 3 settings, because else they're missing UI elements and the UX is inconsistent. shouldn't usually be a problem because gathering the info should be fast, but in your case it's not, hence the hanging.
that's just bizarre 😂️ |
ah, nice, you beat me to it. i wondered and was gonna asked, but i saw (thought) too that you were using Bartender or something similar, and Wooshy wouldn't get the elements for those hidden icons, so i thought it may not matter. my bad. i don't remember seeing any issue with the few times i had Hammerspoon running, but i'll check again with both. thanks. |
ok so i've check with both apps.
in my case also just launching the app hangs my computer. i'll see what i can do. but ultimately 1) i don't think this is a big issue as it's an edge case and happening only when you're in the Settings it seems 2) i'm not gonna go too much out of my way to support app that are really not standard. Wooshy has to use specific macOS APIs and if apps wanna do funky stuff and respect nothing, it's on them. for reference: ScreenFlow.mp4 |
can you try a20? https://github.com/godbout/Wooshy.docs/releases/tag/1.a20 forgot to put in the release notes but there's tweaks for this. it should/may still take a lot of time in your case, but it shouldn't hang anymore. |
No noticeable differences with v1a20.
After more testing, the hanging in Wooshy's preferences appears to be related to the use of window filters in Hammerspoon-- specifically subscribing to window events. This can be consistently reproduced by adding the following Lua snippet to Hammerspoon's init file: -- Test: Window Filter
-- Init window filter
local wf = hs.window.filter
-- Subscribe to app focus/unfocus events
wf.new("Safari")
:subscribe(wf.windowFocused, function ()
print('Safari focused')
end) Note that the window filter is not set to monitor Wooshy's window events. Simply monitoring window events for any app appears to cause a lag in Wooshy's color preferences. I would guess that something similar is going on in PhraseExpress, as it can enable/disable functionality based on the focused app. I understand not spending too much time debugging this issue. I'm just reporting issues as I find them as a dutiful alpha tester 😉 Though, as the issue appears to be related to apps monitoring window events, it may rear its head again in other areas, as these aren't the only two apps to do such things. |
wow. at least i would have expected the hanging to stop, as grabbing the UI Elements is now done in the background (but the UI update is in the foreground, so worst case is you wouldn't have seen the UI refreshed right away). weird.
good, thanks for the precision.
thanks yeah. i don't think it's a big issue if it stays in the Preferences, but my personal issue currently is that i don't understand what's happening. so i'm gonna have to find out first, and then decide if it's worth fixing or not. BUT I NEED TO KNOW!!! 😂️ |
@archetyped are you still seeing the issue? can't on at least Sequoia. |
no answer. can't reproduce. closing. |
Changing the target color setting in the preferences (v1a9) is causes Wooshy to hang for 10+ seconds before the setting is updated.
This makes the "Hue" slider is basically unusable because it gets locked up for 10+ seconds whenever the mouse drag begins.
The text was updated successfully, but these errors were encountered: