Skip to content

Commit 480792b

Browse files
maximlevitskyDavid Woodhouse
authored and
David Woodhouse
committed
mtd: blktrans: kill BKL
It not needed, because I already added locking for all fops methods. Signed-off-by: Maxim Levitsky <[email protected]> Signed-off-by: Artem Bityutskiy <[email protected]> Signed-off-by: David Woodhouse <[email protected]>
1 parent 008c751 commit 480792b

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

drivers/mtd/mtd_blkdevs.c

-6
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode)
181181
if (!dev)
182182
return -ERESTARTSYS; /* FIXME: busy loop! -arnd*/
183183

184-
lock_kernel();
185184
mutex_lock(&dev->lock);
186185

187186
if (dev->open++)
@@ -198,7 +197,6 @@ static int blktrans_open(struct block_device *bdev, fmode_t mode)
198197
unlock:
199198
mutex_unlock(&dev->lock);
200199
blktrans_dev_put(dev);
201-
unlock_kernel();
202200
return ret;
203201
}
204202

@@ -210,7 +208,6 @@ static int blktrans_release(struct gendisk *disk, fmode_t mode)
210208
if (!dev)
211209
return ret;
212210

213-
lock_kernel();
214211
mutex_lock(&dev->lock);
215212

216213
if (--dev->open)
@@ -226,7 +223,6 @@ static int blktrans_release(struct gendisk *disk, fmode_t mode)
226223
unlock:
227224
mutex_unlock(&dev->lock);
228225
blktrans_dev_put(dev);
229-
unlock_kernel();
230226
return ret;
231227
}
232228

@@ -259,7 +255,6 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode,
259255
if (!dev)
260256
return ret;
261257

262-
lock_kernel();
263258
mutex_lock(&dev->lock);
264259

265260
if (!dev->mtd)
@@ -274,7 +269,6 @@ static int blktrans_ioctl(struct block_device *bdev, fmode_t mode,
274269
}
275270
unlock:
276271
mutex_unlock(&dev->lock);
277-
unlock_kernel();
278272
blktrans_dev_put(dev);
279273
return ret;
280274
}

0 commit comments

Comments
 (0)