Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Golem should remove old docker images #4641

Open
7 tasks
etam opened this issue Aug 23, 2019 · 0 comments
Open
7 tasks

Golem should remove old docker images #4641

etam opened this issue Aug 23, 2019 · 0 comments
Labels
P2 Severity-Low/ Effort-easy

Comments

@etam
Copy link
Contributor

etam commented Aug 23, 2019

Rationale

Every time we release new docker images, they are downloaded, but old ones are not removed. After time they can take a lot of disk space (blender verifier takes 1GB!).

Description

When starting golem, it should remove old versions of docker images. If there are any existing containers using them, they should be removed as well.

There should be a command-line option to disable this behavior, because developers might want to change golem versions back and forth (for example develop and release).

QA

Test scenarios:

Base test process

** Smoke Test (the limited set of tests designed to ensure that most critical functionality doesn't experience regressions)

New feature tests

Positive Scenario 1

  • manually download old docker image, for example golemfactory/dummy:1.0
  • launch golem
  • Expected result: golem should remove it

Positive Scenario 1

  • manually download old docker image, for example golemfactory/dummy:1.0
  • launch golem with command-line option that disables removing docker images
  • Expected result: golem should not remove it

Progress

Development

  • Feature implemented
  • Feature unit/integration tests implemented

Dev QA

  • Basic tests by the developer pass
  • Unit tests pass
  • Golem integration tests pass

QA team

  • Base scenario passes

Issues encountered during QA

When adding an issue here, please update testing scenarios and QA progress above

  • link to issue...
@etam etam added the P2 Severity-Low/ Effort-easy label Aug 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Severity-Low/ Effort-easy
Projects
None yet
Development

No branches or pull requests

1 participant