Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test "uv add magika.whl" to windows runner #805

Closed
3 tasks
reyammer opened this issue Nov 20, 2024 · 2 comments · Fixed by #825
Closed
3 tasks

Extend test "uv add magika.whl" to windows runner #805

reyammer opened this issue Nov 20, 2024 · 2 comments · Fixed by #825
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python package

Comments

@reyammer
Copy link
Collaborator

reyammer commented Nov 20, 2024

We recently updated our python github workflows to test that the magika package/wheels can be installed with uv add (in addition to pip install magika). To test this, we use a one-liner that currently works only for ubuntu and macos. We need to extend the one-liner (or add another one) so that it also works for Windows.

These are the workflows to update:

@reyammer reyammer added good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python package labels Nov 20, 2024
@Mohit-Gaur
Copy link
Contributor

@reyammer I'd like to take a stab at this

@reyammer
Copy link
Collaborator Author

Go for it, thanks! Assigned it. The idea would be to add another if, and for windows use some powershell-like syntax to implement the same one-liner. Let me know if you have questions or something is not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed python Pull requests that update Python package
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants