Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IncludeRaiReason to IncludeRAIReason #7

Closed
rakyll opened this issue Dec 13, 2024 · 2 comments
Closed

Rename IncludeRaiReason to IncludeRAIReason #7

rakyll opened this issue Dec 13, 2024 · 2 comments
Assignees
@jscud
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@rakyll
Copy link

rakyll commented Dec 13, 2024

Per initialism conventions in Go, RAI should be all capital. Due to autogeneration, IncludeRaiReason isn't following this convention.
@rakyll rakyll added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 13, 2024
@jscud
Copy link
Collaborator

jscud commented Dec 16, 2024

Great suggestion! As is the case for #8, we'll discuss this proposal and respond back.

@jscud jscud self-assigned this Dec 16, 2024
@jscud
Copy link
Collaborator

jscud commented Dec 17, 2024

Completed, thanks for raising this issue.

@jscud jscud closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jscud jscud

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rakyll @jscud