Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI for lineMetricsVerticalLayout #2054

Open
ollimeier opened this issue Feb 26, 2025 · 8 comments
Open

UI for lineMetricsVerticalLayout #2054

ollimeier opened this issue Feb 26, 2025 · 8 comments

Comments

@ollimeier
Copy link
Collaborator

          > Note: We will add UI for `lineMetricsVerticalLayout` to this PR as we noticed that there is an overlap with `openTypeVheaVertTypoLineGap`.

@justvanrossum I think this requires more and thorough consideration of how we really want to deal with it. There are too many open questions: How would a UI look like? Does it look like "Line metrics" or like "Custom Data". Is it always there, like "Guidelines", even though we don't really need it always? In general I would think it should look like "Line metrics", but we don't set these values always (which differs from "Line Metrics"), and we don't have an add or remove concept for that UI, yet.

Originally posted by @ollimeier in #2039 (comment)

@ollimeier
Copy link
Collaborator Author

Do we need to add top and bottom side bearings for proper compatibility as well?

@ollimeier
Copy link
Collaborator Author

vertTypoAscender: default -> (head.unitsPerEm)/2
It is the distance in font design units from the vertical center baseline to the right edge of the design space for CJK / ideographic glyphs (or “ideographic em box”).

vertTypoDescender: default -> -(head.unitsPerEm)/2
It is the distance in font design units from the vertical center baseline to the left edge of the design space for CJK / ideographic glyphs.

But what is vertical center baseline? And where is it? Is it always the center of a glyph, or at a specific position? How do we display this vertical center baseline?

@ollimeier
Copy link
Collaborator Author

If we add UI for lineMetricsVerticalLayout, do we need vertical type-setting as well? And how would it look like?

@ollimeier
Copy link
Collaborator Author

Do we need a glyph 'hight' similar to 'width' for CJK characters?

@ollimeier
Copy link
Collaborator Author

ollimeier commented Feb 26, 2025

Would it make sense to use the lineMetricsVerticalLayout values for the CJK Design Frame?

@ollimeier
Copy link
Collaborator Author

Do we need 'Zones' for lineMetricsVerticalLayout ?

@ollimeier
Copy link
Collaborator Author

This whole topic requires a lot more thinking then originally expected. As this is not part of Version 1.0 and the time till Version 1.0 is very limited, the best solution for now, might be to add openTypeVheaVertTypoAscender and openTypeVheaVertTypoDescender to ufoInfoAttributesToRoundTrip, so that people can add and edit these values via the font source customData.

@ollimeier
Copy link
Collaborator Author

In a call today, together with @justvanrossum, we agreed on it, that all the questions above are too much to handle now. BUT one possible next step would be to convert the font source 'Line Metrics' section into a ui-list with add and remove buttons (in a separate branch and PR). The add-button opens a dialog where we can select possible options like openTypeVheaVertTypoAscender.

A question, we have not talked about: What happens if we delete one of the default line metrics like 'Baseline' or 'Ascender'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant