Ensure we call flip() on Buffer to avoid Java8 problems (Fixes hieryn…

…omus#705) Signed-off-by: Jeroen van Erp <[email protected]>
gorefest · Mar 19, 2023 · 91e14ca · 91e14ca
1 parent c2afe0a
commit 91e14ca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/com/hierynomus/smbj/transport/tcp/async/AsyncDirectTcpTransport.java b/src/main/java/com/hierynomus/smbj/transport/tcp/async/AsyncDirectTcpTransport.java
@@ -165,7 +165,7 @@ private ByteBuffer prepareBufferToSend(P packet) {
         toSend.order(ByteOrder.BIG_ENDIAN);
         toSend.putInt(packetData.available()); // also writes the initial 0 byte
         toSend.put(packetData.array(), packetData.rpos(), packetData.available());
-        toSend.flip();
+        ((java.nio.Buffer) toSend).flip(); // Java8/9 compatibility
         try {
             packetData.skip(dataSize);
         } catch (BufferException e) {

diff --git a/src/main/java/com/hierynomus/smbj/transport/tcp/async/PacketBufferReader.java b/src/main/java/com/hierynomus/smbj/transport/tcp/async/PacketBufferReader.java
@@ -37,7 +37,7 @@ public <P extends Packet<?>> PacketBufferReader() {
 
 
     public byte[] readNext() {
-        readBuffer.flip(); // prepare to process received data
+        ((java.nio.Buffer) readBuffer).flip(); // prepare to process received data (cast is to avoid Java 8/9 compatibility issues)
         byte[] bytes = null;
         if (isAwaitingHeader() && isHeaderAvailable()) {
             currentPacketLength = readPacketHeader();