Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rely on chain registry for list of supported networks #1744

Closed
alex-pakalniskis opened this issue Oct 15, 2024 · 2 comments
Closed

Rely on chain registry for list of supported networks #1744

alex-pakalniskis opened this issue Oct 15, 2024 · 2 comments
Assignees
@YaroShkvorets
Labels
enhancement New feature or request
Milestone
Decouple Graph CL...

Comments

@alex-pakalniskis
Copy link
Collaborator

alex-pakalniskis commented Oct 15, 2024 •
edited
Loading

Which packages are impacted by your issue?

@graphprotocol/graph-cli

Describe the issue

Subgraph Studio's list of supported networks is currently the "source of truth" for CLI.

Requirements

CLI should have a cache of the supported networks so it doesn't need to contact the internet to get started
@alex-pakalniskis alex-pakalniskis added the enhancement New feature or request label Oct 15, 2024
@alex-pakalniskis alex-pakalniskis moved this to Blocked in Tooling Oct 15, 2024
@matthewdarwin
Copy link
Collaborator

matthewdarwin commented Nov 5, 2024 •
edited by YaroShkvorets
Loading

Additional requirements:

  • It would be good to have a Call-To-Action (CTA) built into the CLI if someone wants to use a chain that is not supported, then the cli prompts them with details how to get that added.
  • the cli should have a cache of the supported networks so it doesn't need to contact the internet to get started.

This was referenced Dec 2, 2024
Closed
Merged
@matthewdarwin matthewdarwin moved this from Blocked to 🔖 Next in Tooling Dec 15, 2024
@matthewdarwin matthewdarwin moved this from 🔖 Next to 🏗 In progress in Tooling Dec 16, 2024
@YaroShkvorets
Copy link
Collaborator

Implemented in v0.93.0

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Tooling Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YaroShkvorets YaroShkvorets

Labels
enhancement New feature or request
Projects
Tooling
Status: ✅ Done
Milestone
Decouple Graph CLI from Subgraph Studio
Development

No branches or pull requests
3 participants
@matthewdarwin @YaroShkvorets @alex-pakalniskis