Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-02] EVERYONE: Review Section 1: Overview #128

Closed
benjie opened this issue Feb 1, 2024 · 3 comments
Closed

[2024-02] EVERYONE: Review Section 1: Overview #128

benjie opened this issue Feb 1, 2024 · 3 comments
Labels
Action item 🎬 Everyone 🌐 Need everyone to look at this

Comments

@benjie
Copy link
Member

benjie commented Feb 1, 2024

Though a lot of the spec text is still in very heavy flux, a lot of effort has been put into Section 1 to ensure it captures what we're setting out to solve in this working group/specification. Please read it, and if there's anything you disagree with or feel is missing, please raise an issue!


Note: Action Item issues are reviewed and closed during Working Group
meetings.

@benjie benjie added Action item 🎬 Everyone 🌐 Need everyone to look at this labels Feb 1, 2024
@smyrick
Copy link
Contributor

smyrick commented Feb 1, 2024

For everyone, here is the link to Section 1 -- Overview.md https://github.com/graphql/composite-schemas-spec/blob/main/spec/Section%201%20--%20Overview.md

Spec docs are over the separate repo: https://github.com/graphql/composite-schemas-spec


Edit: Section 1 LGTM, no changes from my side

@bignimbus
Copy link
Contributor

Section 1 LGTM as well 👍🏻

@JohnStarich
Copy link
Contributor

Section 1 LGTM.

I particularly like the choice of "encourages" rather than "requires" in the Composable section. That will be key for folks to grow their source graphs' complexity gradually. In other words, it'd be more likely a single source schema is composable from day 1.

@benjie benjie closed this as completed Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Everyone 🌐 Need everyone to look at this
Projects
None yet
Development

No branches or pull requests

4 participants