Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint and other packages once eslint bug is fixed #132

Open
vincerubinetti opened this issue Aug 21, 2019 · 2 comments
Open

Upgrade eslint and other packages once eslint bug is fixed #132

vincerubinetti opened this issue Aug 21, 2019 · 2 comments
Labels
todo An action item

Comments

@vincerubinetti
Copy link
Collaborator

Big babel-eslint issue causing false positives for the no-unused-vars rule:
eslint/eslint#12117

This issue is a reminder/tracker to update react-scripts, eslint, and any other packages that are out-of-date or that were version locked to work-around this error.

Also, remove eslint from dependencies and peerDependencies.

@vincerubinetti vincerubinetti added the todo An action item label Aug 21, 2019
@vincerubinetti
Copy link
Collaborator Author

eslint and babel-eslint were fixed a couple of days ago, but I was waiting on create-react-app to be updated as well because it includes those two packages in (I think) pinned versions.

But for the heck of it I tried removing the manual eslint pin from my package.json, and updating all the packages, and it doesn't throw the false positive error anymore. Either I was wrong and create-react-app specifies a non-pinned/latest version of estlint and so it was automatically a non-issue, or the newer fixed version of eslint is being specified from some other package and overriding the broken version in create-react-app.

@vincerubinetti
Copy link
Collaborator Author

I am dumb. I think it was my own hetio frontend-components with the eslint pin that was preventing the error. So even though I removed the eslint pin from this repo and it worked fine, I'm not considering this fixed yet.

Looks like create-react-app really needs to fix this upstream ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo An action item
Projects
None yet
Development

No branches or pull requests

1 participant