Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx config #47

Closed
amg-web opened this issue Jul 29, 2020 · 9 comments
Closed

nginx config #47

amg-web opened this issue Jul 29, 2020 · 9 comments
Labels
documentation Improvements or additions to documentation

Comments

@amg-web
Copy link
Contributor

amg-web commented Jul 29, 2020

The better way to place nginx config for exporter is
/etc/bigbluebutton/nginx/metrics.nginx

it will not be overwritten during update

@greenstatic
Copy link
Owner

I agree it is better practice to separate the Nginx site configuration to prevent it from being overwritten during BBB upgrading. This is also mentioned in the docs, however it requires for a separate HTTPS certificate.

@amg-web
Copy link
Contributor Author

amg-web commented Jul 30, 2020

if you open /etc/nginx/sites-available/bigbluebutton
you will find this line
include /etc/bigbluebutton/nginx/*.nginx;

that's why I mentioned it in previous message

@greenstatic greenstatic reopened this Sep 15, 2020
@greenstatic greenstatic added the documentation Improvements or additions to documentation label Sep 15, 2020
@greenstatic
Copy link
Owner

Hmm I never noticed that. That's an interesting idea! One thing personally though is that I sort of expect all Nginx configs to be in /etc/nginx/sites-available. I think it would hurt readability a bit, but on the second hand I suppose bbb leaves the directory alone during an upgrade? Do you have any experience regarding that?

@amg-web
Copy link
Contributor Author

amg-web commented Sep 15, 2020

sure. no problem.
Greenlight drops its' config there

@greenstatic
Copy link
Owner

That's good news. I think I'll fix the documentation to reflect your recommendation. Thanks!

You are also welcome to submit a PR :)

@amg-web
Copy link
Contributor Author

amg-web commented Sep 16, 2020

You are also welcome to submit a PR :)
What do you mean PR ?

@greenstatic
Copy link
Owner

PR = Pull request

@amg-web
Copy link
Contributor Author

amg-web commented Sep 25, 2020

I made it :)

@greenstatic
Copy link
Owner

Great, thanks!

Merged in #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants