Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Include Without Label #3882

Open
yhakbar opened this issue Feb 13, 2025 · 0 comments
Open

Deprecate Include Without Label #3882

yhakbar opened this issue Feb 13, 2025 · 0 comments
Labels
preserved Preserved issues never go stale

Comments

@yhakbar
Copy link
Collaborator

yhakbar commented Feb 13, 2025

For backwards compatibility, we support the ability to define include blocks without labels.

This results in a double parse of HCL files, as the HCL parser requires the exact number of labels to be known for every include block:
https://github.com/gruntwork-io/terragrunt/blob/a02986/config/hclparse/file.go#L56

Similar to the deprecation of inputs from dependencies, we can provide a performance improvement for users that aren't using this legacy syntax by introducing a strict control that prevents usage of include blocks without labels, and skipping the secondary parse.

Given that Terragrunt has supported this for a long time, we shouldn't look to remove support for includes without labels until well after 1.0.

@yhakbar yhakbar added the preserved Preserved issues never go stale label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preserved Preserved issues never go stale
Projects
None yet
Development

No branches or pull requests

1 participant