Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out perf.data parsing into a separate crate #2

Open
jonhoo opened this issue Dec 3, 2016 · 2 comments
Open

Factor out perf.data parsing into a separate crate #2

jonhoo opened this issue Dec 3, 2016 · 2 comments

Comments

@jonhoo
Copy link

jonhoo commented Dec 3, 2016

I'm looking into building a tool to analyze and visualize perf.data files, and the parser code in https://github.com/gz/rust-perfcnt/blob/master/src/linux/parser.rs would be really handy to re-use. Would you consider factoring it out into its own crate at some point?

@gz
Copy link
Owner

gz commented Dec 14, 2016

Hi, First of all, sorry for not replying earlier. Last few days have been quite busy.
AFAIK you should already be able to use perfcnt as a library and include the parser from there. Is that not sufficient for your use-case? Let me know. I'm happy to make the parsing code more accessible for others.

@jonhoo
Copy link
Author

jonhoo commented Dec 14, 2016

No worries at all :)
You're right, I could do that. Given that the parsing code is entirely self-contained though, it seems like a good candidate for making its own library, which can eventually be documented and tested in isolation. This also encourages re-use, since it'll be easier for people to find a crate dedicated to parsing perf.data than to find a module hidden within a create that seems fairly unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants