Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchark with missings #54

Closed
skanskan opened this issue Dec 5, 2018 · 3 comments
Closed

Add benchark with missings #54

skanskan opened this issue Dec 5, 2018 · 3 comments
Milestone

Comments

@skanskan
Copy link

skanskan commented Dec 5, 2018

It would also be interesting to see how fast are all these tools when the data contains missings.

@jangorecki
Copy link
Contributor

jangorecki commented Dec 6, 2018

Thanks for feedback, we have that tests done. The problem is that pandas does not support NAs in columns you are grouping by. It requires to replace NAs with sentinel value (like -1). And just this would require to have 2 different benchmark script for pandas, and that would obviously complicate whole workflow which is agnostic to presence of NAs.
We will definitely add that case, but I still hope pandas will manage to resolve that issue for 0.24.0 and we will not have to maintain another exception. Related issue in pandas repo: pandas-dev/pandas#3729 requested in 2013.
Closing this issue as duplicate of #40.

@jangorecki
Copy link
Contributor

Re-opening as the linked issue asked about groupby task only.
I am now working on groupby. I will keep this issue open for join task.

@jangorecki jangorecki reopened this Dec 13, 2020
@jangorecki
Copy link
Contributor

It has been added and report has been refreshed.

Tmonster pushed a commit to Tmonster/db-benchmark that referenced this issue Jun 6, 2024
Thanks! Planning on running all the solutions again soon on latest versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants