Add float_precision parameter to to_pomdp_file() #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkytony
reviewed
May 23, 2023
Hororohoruru
force-pushed
the
float-precision
branch
from
da26b4b to
6170994
Compare
zkytony
added a commit
that referenced
this pull request
Jul 25, 2023
* allow updating rollout policy * NotImplemented->NotImplementedError in oopomdp.pyx * s -> sp in ValueIteration (#20) * add __init__ signature for Environment in comments to be visible in docs * added float_precision argument to to_pomdp_file (#29) * add readme instruction to run load_unload * oops - correction * Fix cpdef on variable * version bump; sorting MANIFEST.in * fix setup cython extension in pomdp_problems * auto-generate manifest to include .pyx * update changelog * Fix wheel build * docs html build * change set to list in tiger to tame random.sample in python 3.11 * docs html build * bump minimum python requirement * update docs accordingly --------- Co-authored-by: Juan Jesús Torre Tresols <[email protected]> Co-authored-by: Jiuguang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #28, a particular case where the uniform belief over states is a periodic number (0.083333333 in this case) created an error when running SARSOP on the
.pomdpfile created byto_pomdp_file(). This was because the float to str conversion defaults to 6 decimals.Adding a parameter to control for this precision in
to_pomdp_file()fixed the issue.