Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook in APIs to filtered permissions data component #1801

Open
9 of 10 tasks
Tracked by #1737
JackHaeg opened this issue Oct 22, 2024 · 8 comments · May be fixed by #1853
Open
9 of 10 tasks
Tracked by #1737

Hook in APIs to filtered permissions data component #1801

JackHaeg opened this issue Oct 22, 2024 · 8 comments · May be fixed by #1853
Assignees
Labels
p-feature: API p-feature: User Permissions Feature includes how user access levels / user permissions will be implemented in the product ready for dev lead Add to issue when dev lead needs to take some action role: Back End size: 2pt Can be done in 7-12 hours

Comments

@JackHaeg
Copy link
Member

JackHaeg commented Oct 22, 2024

Dependency

git fetch vrms # or "git fetch upstream" depending on your remotes configuration
git branch user_permissions_search
git checkout -b [new branch name]

Overview

This issue represents the final step in the User Permission Search Epic. The objective is to remove the placeholder dummy data currently used in the "User Permission Search" screen and integrate the APIs developed earlier in the Epic. Once completed, the filtered permissions data component will be fully functional and ready for production.

Action Items

  • Remove Dummy Data
    • Identify and remove all instances of dummy/placeholder data from the "User Permission Search" screen and filtered permissions data component.
  • API Integration
  • Testing
    • Verify the full flow from user input to permission search results.
    • Ensure that the search results update dynamically based on input filters.
    • Conduct both unit tests and end-to-end tests to validate the functionality and catch any edge cases.

Resources/Instructions

Screenshot of User Permission Search Screen mockups

Screenshot 2024-10-07 at 8 30 51 PM

@github-project-automation github-project-automation bot moved this to New Issue Approval in P: VRMS: Project Board Oct 22, 2024
@JackHaeg JackHaeg added role: Back End Dependency - Icebox size: 2pt Can be done in 7-12 hours p-feature: API p-feature: User Permissions Feature includes how user access levels / user permissions will be implemented in the product labels Oct 22, 2024
@JackHaeg JackHaeg added Dependency - Icebox ready for dev lead Add to issue when dev lead needs to take some action and removed Dependency - Icebox labels Oct 22, 2024
@JackHaeg
Copy link
Member Author

JackHaeg commented Nov 5, 2024

@trillium Please add an action item to address any remaining dummy data objects, values, or properties not currently included in our code, as noted by Vorleak in this PR #1808 (comment)

@JackHaeg
Copy link
Member Author

JackHaeg commented Jan 21, 2025

@vorleakyek this issue is cleared to be worked on now that the PRs have been merged. Given that you expressed interested in working on this issue previously (and you have worked on previous issues in this Epic), I went ahead and assigned you to the issue / placed the issue in progress. Please let me know if you are okay with this by liking this comment. Also, please reach out to @trillium if you have any questions!

@JackHaeg JackHaeg moved this from Prioritized Backlog to In progress in P: VRMS: Project Board Jan 21, 2025
@JackHaeg

This comment has been minimized.

@vorleakyek
Copy link
Member

Hi @JackHaeg!

Progress: I started to take a look at how the API was implemented in 1771 - API for Fetching Project Managers #1799.
Blockers: There were comments under that PR, so I'm trying to understand and resolve it.
Availability: I'm available 3-6 hrs this week.
ETA: possible in 1 or 2 weeks

@JackHaeg
Copy link
Member Author

Thanks for the update @vorleakyek! Please reach out to @trillium with any questions related to the comments on the PR you mentioned in your comment above.

@JackHaeg
Copy link
Member Author

JackHaeg commented Feb 4, 2025

Hi @vorleakyek! When you have a moment, can you please provide an update with the following information:

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@vorleakyek
Copy link
Member

Hi @JackHaeg!

Progress: I had to adjust the data structure fetched from the project lead API (#1799) to match the frontend dummy data. I'm almost done with it. So, I'll have PR up probably by Wednesday.
Blockers: I might have to dig into unit tests since I'm not familiar with it.
Availability: I'm available 3-6 hrs this week.
ETA: I should have a PR up by Wednesday.

@JackHaeg
Copy link
Member Author

JackHaeg commented Feb 4, 2025

Thanks for the update, @vorleakyek! Looking forward to checking out the PR soon :)

@vorleakyek vorleakyek linked a pull request Feb 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p-feature: API p-feature: User Permissions Feature includes how user access levels / user permissions will be implemented in the product ready for dev lead Add to issue when dev lead needs to take some action role: Back End size: 2pt Can be done in 7-12 hours
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants