Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when trying to merge Locon with multiple dimensions #380

Open
Zolilio opened this issue May 18, 2024 · 1 comment · Fixed by #381
Open

Problem when trying to merge Locon with multiple dimensions #380

Zolilio opened this issue May 18, 2024 · 1 comment · Fixed by #381

Comments

@Zolilio
Copy link
Contributor

Zolilio commented May 18, 2024

I've noticed that the extension give me an error when trying to merge Locon with uneven network and conv dimensions (even when I try to merge one single Locon).
Here the error:

Traceback (most recent call last):
  File "C:\Users\XXX\AI\webui_forge_cu121_torch21\webui\extensions\sd-webui-supermerger\scripts\mergers\pluslora.py", line 393, in lmerge
    d = list(set(d.values()))
AttributeError: 'list' object has no attribute 'values'

Checked how this type of Lora was handled by the code and I found in pluslora.py file the part responsible for the issue (line 393):

if t == "LoCon" and isinstance(d, list):
                d = list(set(d.values()))
                d = d[0]

I've erased the d = list(set(d.values())) line, and now the error is gone. However, the results I got when merging where a bit off. It looked like the effect of the Lora was weakened and I'm not sure if it's because the code missed some information to do a good merge or just an error from my part.

If someone that know how the code work could help me here I would be very pleased :)

@hako-mikan
Copy link
Owner

May be fixed.
Thanks @Zolilio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants