Dialog: Update position when size is changed. Fixes #8789 - Dialog does not close for first click on chrome.

kborchers · jzaefferer · commit d179cbaf3233 · 2012-11-26T10:28:25.000+01:00
diff --git a/tests/visual/dialog/complex-dialogs.html b/tests/visual/dialog/complex-dialogs.html
@@ -24,7 +24,6 @@
 	$(function() {
 		var dialog = $( "#dialog" ).dialog({
 				modal: true,
-				height: 350,
 				width: 500,
 				buttons: [
 					{
@@ -45,7 +44,7 @@
 						showText: false
 					}
 				]
-			}),
+			}).dialog("option", "height", 600),
 
 			datepickerDialog = $( "#dialog-datepicker" ).dialog({
 				autoOpen: false,
diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js
@@ -527,6 +527,7 @@ $.widget("ui.dialog", {
 
 		if ( resize ) {
 			this._size();
+			this._position();
 		}
 		if ( this.uiDialog.is( ":data(ui-resizable)" ) ) {
 			this.uiDialog.resizable( "option", resizableOptions );

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`$(function() {`
`25`	`25`	`var dialog = $( "#dialog" ).dialog({`
`26`	`26`	`modal: true,`
`27`		`- height: 350,`
`28`	`27`	`width: 500,`
`29`	`28`	`buttons: [`
`30`	`29`	`{`
`@@ -45,7 +44,7 @@`
`45`	`44`	`showText: false`
`46`	`45`	`}`
`47`	`46`	`]`
`48`		`- }),`
	`47`	`+ }).dialog("option", "height", 600),`
`49`	`48`
`50`	`49`	`datepickerDialog = $( "#dialog-datepicker" ).dialog({`
`51`	`50`	`autoOpen: false,`
Original file line number	Diff line number	Diff line change
`@@ -527,6 +527,7 @@ $.widget("ui.dialog", {`
`527`	`527`
`528`	`528`	`if ( resize ) {`
`529`	`529`	`this._size();`
	`530`	`+ this._position();`
`530`	`531`	`}`
`531`	`532`	`if ( this.uiDialog.is( ":data(ui-resizable)" ) ) {`
`532`	`533`	`this.uiDialog.resizable( "option", resizableOptions );`