Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 8.4.0 + Clippy fixes + disable CORETEXT #37

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Update to 8.4.0 + Clippy fixes + disable CORETEXT #37

merged 3 commits into from
Jul 1, 2024

Conversation

asibahi
Copy link
Contributor

@asibahi asibahi commented Apr 12, 2024

Update submodule to 8.4.0 and clippy fixes are straightforward enough, I hope. They compile and run the sample on my machine.

In the build.rs I commented out compiling for the CORETEXT libraries, as apparently MacOS on ARM has them somewhere else (Similar to iOS?). I could not figure out how to translate the relevant parts from the meson build into build.rs . So I commented them out to make it compile.

band aid over #36 .

@asibahi asibahi changed the title Update to 8.4.0 + Clip fixes + disable CORETEXT (bandaid for https://github.com/harfbuzz/harfbuzz_rs/issues/36) Update to 8.4.0 + Clip fixes + disable CORETEXT Apr 12, 2024
@asibahi asibahi changed the title Update to 8.4.0 + Clip fixes + disable CORETEXT Update to 8.4.0 + Clippy fixes + disable CORETEXT Apr 12, 2024
@behdad behdad merged commit 1f26fe6 into harfbuzz:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants