Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainance vector-0.10.12 release (AMP fix) #45

Closed
hvr opened this issue Sep 28, 2014 · 3 comments
Closed

Maintainance vector-0.10.12 release (AMP fix) #45

hvr opened this issue Sep 28, 2014 · 3 comments
Assignees

Comments

@hvr
Copy link
Member

hvr commented Sep 28, 2014

It may be beneficial to have a vector-0.10.12 release fixing the AMP warnings, as that's all that's currently needed in order to be able to build vector == 0.10.* w/ GHC HEAD. This would make the transition smoother w/ GHC 7.10 and packages still relying on vector == 0.10.*

The following change is all that's currently needed:

diff --git a/Data/Vector/Fusion/Util.hs b/Data/Vector/Fusion/Util.hs
index c84abbb..1b6d5ed 100644
--- a/Data/Vector/Fusion/Util.hs
+++ b/Data/Vector/Fusion/Util.hs
@@ -22,6 +22,10 @@ newtype Id a = Id { unId :: a }
 instance Functor Id where
   fmap f (Id x) = Id (f x)

+instance Applicative Id where
+  pure = Id
+  Id f <*> Id x = Id (f x)
+
 instance Monad Id where
   return     = Id
   Id x >>= f = f x
@@ -32,6 +36,10 @@ data Box a = Box { unBox :: a }
 instance Functor Box where
   fmap f (Box x) = Box (f x)

+instance Applicative Box where
+  pure = Box
+  Box f <*> Box x = Box (f x)
+
 instance Monad Box where
   return      = Box
   Box x >>= f = f x

/cc @EdwardK

@hvr hvr changed the title Maintainance vector-0.10.12 release Maintainance vector-0.10.12 release (AMP fix) Sep 28, 2014
@hvr
Copy link
Member Author

hvr commented Oct 4, 2014

@dolio bump

@kolmodin
Copy link
Member

ping

@dolio
Copy link
Contributor

dolio commented Oct 11, 2014

Fixed

@dolio dolio closed this as completed Oct 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants