Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribe to supply/borrow events rather than full update in Worker #54

Open
haydenshively opened this issue Aug 31, 2020 · 2 comments
Open
Labels
architecture Changes that result in better architecture or typing performance Changes that result in more speed or efficiency v3

Comments

@haydenshively
Copy link
Owner

Even pulling from the local Geth node takes ~2 seconds for 50 accounts. This is horribly slow. If we subscribe to supply and borrow events and update on an as-needed basis, rather than re-loading all data for every account every time, we can speed things up substantially and increase the number of accounts that we're watching (e.g. take it from 50 -> 5000)

@haydenshively haydenshively added performance Changes that result in more speed or efficiency next labels Aug 31, 2020
@haydenshively
Copy link
Owner Author

We're missing out on liquidations because we can't watch enough accounts at once. When markets are volatile, this is extra bad.

@haydenshively haydenshively added this to the September Polish milestone Sep 6, 2020
@haydenshively haydenshively added architecture Changes that result in better architecture or typing v3 and removed next labels Oct 31, 2020
@mpereiraesaa
Copy link

We're missing out on liquidations because we can't watch enough accounts at once. When markets are volatile, this is extra bad.

Have you checked if there are limits on adding listeners for example over 10, 20 etc contracts in order to watch accounts, comptroller, tokens etc Why we can't watch enough accounts at once?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Changes that result in better architecture or typing performance Changes that result in more speed or efficiency v3
Projects
None yet
Development

No branches or pull requests

2 participants