Skip to content

Commit

Permalink
Merge pull request NixOS#94102 from q3k/q3k/xbattbar
Browse files Browse the repository at this point in the history
xbattbar: init at 1.4.9
  • Loading branch information
Lassulus authored Sep 8, 2020
2 parents c26026f + 4733735 commit 8afc303
Show file tree
Hide file tree
Showing 3 changed files with 74 additions and 0 deletions.
46 changes: 46 additions & 0 deletions pkgs/applications/misc/xbattbar/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{ stdenv, fetchgit, libX11, perl, ... }:

stdenv.mkDerivation rec {
pname = "xbattbar";
version = "1.4.9";

# The current active upstream of xbattbar seems to be the Debian source
# repository.
src = fetchgit {
url = "https://salsa.debian.org/debian/xbattbar.git";
rev = "upstream/${version}";
sha256 = "10w7gs0l4hzhdn38yqyr3az7n4ncmfnd6hhhly6lk5dg7k441ck6";
};

buildInputs = [ libX11 ];

# The following patches are applied:
# - sys-by-default: remove the APM checker binary, make the sys checker
# script the default. Rationale: checking battery status by /proc/apm is
# extremely oldschool and does not work on NixOS, while the sysfs script
# does.
# - perl shebang patches for acpi/sys scripts
# - unhardcode path to checker scripts
patchPhase = ''
patch -p1 < ${./sys-by-default.patch}
sed -i -e "s,/usr/lib/xbattbar/,$out/libexec/," xbattbar.c
sed -i -e "s,/usr/bin/perl,${perl}/bin/perl," xbattbar-check-acpi
sed -i -e "s,/usr/bin/perl,${perl}/bin/perl," xbattbar-check-sys
'';

installPhase = ''
mkdir -p $out/bin
mkdir -p $out/libexec
install -m 0755 xbattbar $out/bin/
install -m 0755 xbattbar-check-acpi $out/libexec/
install -m 0755 xbattbar-check-sys $out/libexec/
'';

meta = with stdenv.lib; {
description = "Display battery status in X11";
homepage = "https://salsa.debian.org/debian/xbattbar";
license = licenses.gpl2Plus;
platforms = platforms.linux;
maintainers = [ maintainers.q3k ];
};
}
26 changes: 26 additions & 0 deletions pkgs/applications/misc/xbattbar/sys-by-default.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
diff --git a/xbattbar.c b/xbattbar.c
index 1e26019..cb3eab5 100644
--- a/xbattbar.c
+++ b/xbattbar.c
@@ -75,9 +75,8 @@ char *ONOUT_C = "olive drab";
char *OFFIN_C = "blue";
char *OFFOUT_C = "red";

-char *EXTERNAL_CHECK = "/usr/lib/xbattbar/xbattbar-check-apm";
+char *EXTERNAL_CHECK = "/usr/lib/xbattbar/xbattbar-check-sys";
char *EXTERNAL_CHECK_ACPI = "/usr/lib/xbattbar/xbattbar-check-acpi";
-char *EXTERNAL_CHECK_SYS = "/usr/lib/xbattbar/xbattbar-check-sys";

int alwaysontop = False;

@@ -245,10 +244,6 @@ main(int argc, char **argv)
EXTERNAL_CHECK = EXTERNAL_CHECK_ACPI;
break;

- case 'r':
- EXTERNAL_CHECK = EXTERNAL_CHECK_SYS;
- break;
-
case 's':
EXTERNAL_CHECK = optarg;
break;
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -24022,6 +24022,8 @@ in
xautomation = callPackage ../tools/X11/xautomation { };

xawtv = callPackage ../applications/video/xawtv { };

xbattbar = callPackage ../applications/misc/xbattbar { };

xbindkeys = callPackage ../tools/X11/xbindkeys { };

Expand Down

0 comments on commit 8afc303

Please sign in to comment.