Skip to content

Commit 5ce4c03

Browse files
author
Stefan Hartmann
committed
remove the special street number
1 parent dc91f99 commit 5ce4c03

13 files changed

+28
-140
lines changed

README.md

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
SpreeGermanMarket
22
=================
33

4-
Extends the spreecommerce for being more german market ready. Assumes a german country.
4+
Configure and extend spreecommerce for being more german market ready. Assumes a german country.
55

66
- Alters the address fields
7-
- Change the final save and continue button caption
8-
- Adds some declarations and translations.
7+
- Change the final save and continue button caption
8+
- Adds some declarations and translations.
99
- Adds a german zone, german tax categories/rates and a default flat german shipping method.
1010
- Remove germany from all other zones.
1111
- Set germany as default checkout zone and default country id.
@@ -18,7 +18,7 @@ Installation
1818
Add spree_german_market to your Gemfile:
1919

2020
```ruby
21-
gem 'spree_german_market', :git => 'git://github.com/hefan/spree_german_market.git'
21+
gem 'spree_german_market', :git => 'git://github.com/hefan/spree_german_market.git'
2222
```
2323

2424
For a specific version use the appropriate branch, for example
@@ -65,5 +65,3 @@ Simply add this require statement to your spec_helper:
6565
```ruby
6666
require 'spree_german_market/factories'
6767
```
68-
69-

app/models/spree/address_decorator.rb

-9
This file was deleted.

app/overrides/address_vcart_street_number.rb

-4
This file was deleted.

app/overrides/admin_address_display_street_number.rb

-4
This file was deleted.

app/views/spree/address/_form.html.erb

+22-10
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,18 @@
1+
Skip to content
2+
This repository
3+
Explore
4+
Gist
5+
Blog
6+
Help
7+
stefan hefan
8+
9+
338 Watch
10+
Star 5,699
11+
Fork 2,647spree/spree
12+
branch: 2-4-stable spree / frontend / app / views / spree / address / _form.html.erb
13+
Matthew FenelonMattFenelon on Mar 30 Allowed for client side validation of phone number and zip code to be…
14+
2 contributors Ryan BiggMatthew Fenelon
15+
76 lines (72 sloc) 3.505 kb RawBlameHistory
116
<% address_id = address_type.chars.first %>
217
<div class="inner" data-hook=<%="#{address_type}_inner" %>>
318
<p class="field" id=<%="#{address_id}firstname" %>>
@@ -14,17 +29,13 @@
1429
<%= form.text_field :company %>
1530
</p>
1631
<% end %>
17-
<p class="field" id="<%="#{address_id}address1" %>">
32+
<p class="field" id=<%="#{address_id}address1" %>>
1833
<%= form.label :address1, Spree.t(:street_address) %><span class="required">*</span><br />
1934
<%= form.text_field :address1, :class => 'required' %>
2035
</p>
21-
<p class="field" id="<%="#{address_id}street_number" %>">
22-
<%= form.label :street_number, Spree.t(:street_number) %><span class="required">*</span><br />
23-
<%= form.text_field :street_number, :class => 'required' %>
24-
</p>
2536
<p class="field" id=<%="#{address_id}zipcode" %>>
26-
<%= form.label :zipcode, Spree.t(:zip) %><span class="required">*</span><br />
27-
<%= form.text_field :zipcode, :class => 'required' %>
37+
<%= form.label :zipcode, Spree.t(:zip) %><% if address.require_zipcode? %><span class="required">*</span><br /><% end %>
38+
<%= form.text_field :zipcode, :class => "#{'required' if address.require_zipcode?}" %>
2839
</p>
2940
<p class="field" id=<%="#{address_id}city" %>>
3041
<%= form.label :city, Spree.t(:city) %><span class="required">*</span><br />
@@ -63,8 +74,8 @@
6374
<% end %>
6475

6576
<p class="field" id=<%="#{address_id}phone" %>>
66-
<%= form.label :phone, Spree.t(:phone) %><span class="required">*</span><br />
67-
<%= form.phone_field :phone, :class => 'required' %>
77+
<%= form.label :phone, Spree.t(:phone) %><% if address.require_phone? %><span class="required">*</span><br /><% end %>
78+
<%= form.phone_field :phone, :class => "#{'required' if address.require_phone?}" %>
6879
</p>
6980
<% if Spree::Config[:alternative_shipping_phone] %>
7081
<p class="field" id=<%="#{address_id}altphone" %>>
@@ -73,4 +84,5 @@
7384
</p>
7485
<% end %>
7586
</div>
76-
87+
Status API Training Shop Blog About
88+
© 2014 GitHub, Inc. Terms Privacy Security Contact

app/views/spree/admin/shared/_address_form.html.erb

-72
This file was deleted.

app/views/store/admin/_display_address.html.erb

-4
This file was deleted.

config/locales/de.yml

-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,3 @@
44
de:
55
buy: "Jetzt kaufen"
66
buy_declaration: "Mit Betätigungs des 'Jetzt Kaufen'-Knopfes bestätigen Sie unsere Allgemeinen Geschäftsbedingungen (AGB) und Datenschutzbestimmungen."
7-
8-
spree:
9-
street_number: "Hausnr"

config/locales/en.yml

-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,3 @@
44
en:
55
buy: "Buy"
66
buy_declaration: "By Clicking the 'Buy'-Button you accept our general terms and conditions and data protection regulations."
7-
8-
spree:
9-
street_number: "Street Number"

db/migrate/20140330035200_add_street_number_to_addresses.rb

-5
This file was deleted.

lib/spree_german_market/engine.rb

-2
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ def self.activate
1717
end
1818
end
1919

20-
Spree::PermittedAttributes.address_attributes << :street_number
21-
2220
config.to_prepare &method(:activate).to_proc
2321
end
2422
end

spec/models/spree/address_spec.rb

-16
This file was deleted.

spree_german_market.gemspec

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
Gem::Specification.new do |s|
33
s.platform = Gem::Platform::RUBY
44
s.name = 'spree_german_market'
5-
s.version = '2.3.0'
5+
s.version = '2.4.0'
66
s.summary = 'Spree Extension for german market'
77
s.description = 'change checkout and add default date for german market'
88
s.required_ruby_version = '>= 1.9.3'
@@ -15,7 +15,7 @@ Gem::Specification.new do |s|
1515
s.require_path = 'lib'
1616
s.requirements << 'none'
1717

18-
s.add_dependency 'spree_core', '~> 2.3'
18+
s.add_dependency 'spree_core', '~> 2.4'
1919

2020
s.add_development_dependency 'capybara', '~> 2.1'
2121
s.add_development_dependency 'coffee-rails'

0 commit comments

Comments
 (0)