Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFA can respond with different user than requested #37

Closed
dmulder opened this issue Sep 12, 2023 · 0 comments
Closed

MFA can respond with different user than requested #37

dmulder opened this issue Sep 12, 2023 · 0 comments
Assignees
@dmulder
Labels
bug Something isn't working

Comments

@dmulder
Copy link
Collaborator

dmulder commented Sep 12, 2023

Because the DAG requests the username again, we could potentially end up with a auth token for a different user than initially requested. We need to ensure this isn't allowed.
@dmulder dmulder added the bug Something isn't working label Sep 12, 2023
@dmulder dmulder self-assigned this Sep 12, 2023
dmulder added a commit that referenced this issue Sep 12, 2023
@dmulder
Prohibit authentication with changing IDs
e9c68fe 
It's possible for a MFA DAG request to respond
with a successful auth for a user other than the
originally requested user. This could corrupt our
cache and process pam_allow_groups incorrectly.

BUG: #37

Signed-off-by: David Mulder <[email protected]>
@dmulder dmulder mentioned this issue Sep 12, 2023
Merged
@dmulder dmulder closed this as completed Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmulder dmulder

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmulder