forked from moodle/moodle
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathcore_renderer_template_exploit_test.php
443 lines (431 loc) · 16.6 KB
/
core_renderer_template_exploit_test.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
namespace core;
/**
* Unit tests for core renderer render template exploit.
*
* @package core
* @category test
* @copyright 2019 Ryan Wyllie <[email protected]>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class core_renderer_template_exploit_test extends \advanced_testcase {
/**
* Test cases to confirm that blacklisted helpers are stripped from the source
* text by the helper before being passed to other another helper. This prevents
* nested calls to helpers.
*/
public function get_template_testcases() {
// Different helper implementations to test various combinations of nested
// calls to render the templates.
$norender = function($text) {
return $text;
};
$singlerender = function($text, $helper) {
return $helper->render($text);
};
$recursiverender = function($text, $helper) {
$result = $helper->render($text);
while (strpos($result, '{{') != false) {
$result = $helper->render($result);
}
return $result;
};
return [
'nested JS helper' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{#js}} some nasty JS {{/js}}{{/testpix}}',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $singlerender
],
'js' => 'some nasty JS',
'expected' => 'core, move,',
'include' => false
],
'other nested helper' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{#test1}} some text {{/test1}}{{/testpix}}',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $singlerender,
'test1' => $norender,
],
'js' => 'some nasty JS',
'expected' => 'core, move, some text',
'include' => false
],
'double nested helper' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{#test1}} some text {{#js}} some nasty JS {{/js}} {{/test1}}{{/testpix}}',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $singlerender,
'test1' => $norender,
],
'js' => 'some nasty JS',
'expected' => 'core, move, some text {{}}',
'include' => false
],
'js helper not nested' => [
'templates' => [
'test' => '{{#testpix}} core, move, some text {{/testpix}}{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $singlerender
],
'js' => 'some nasty JS',
'expected' => 'core, move, some text',
'include' => true
],
'js in context not in helper' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{/testpix}}{{hack}}',
],
'torender' => 'test',
'context' => [
'hack' => '{{#js}} some nasty JS {{/js}}'
],
'helpers' => [
'testpix' => $singlerender
],
'js' => 'some nasty JS',
'expected' => 'core, move, {{#js}} some nasty JS {{/js}}',
'include' => false
],
'js in context' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{hack}}{{/testpix}}',
],
'torender' => 'test',
'context' => [
'hack' => '{{#js}} some nasty JS {{/js}}'
],
'helpers' => [
'testpix' => $singlerender
],
'js' => 'some nasty JS',
'expected' => 'core, move, {{}}',
'include' => false
],
'js in context double depth with single render' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{first}}{{/testpix}}',
],
'torender' => 'test',
'context' => [
'first' => '{{second}}',
'second' => '{{#js}} some nasty JS {{/js}}'
],
'helpers' => [
'testpix' => $singlerender
],
'js' => 'some nasty JS',
'expected' => 'core, move, {{second}}',
'include' => false
],
'js in context double depth with recursive render' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{first}}{{/testpix}}',
],
'torender' => 'test',
'context' => [
'first' => '{{second}}',
'second' => '{{#js}} some nasty JS {{/js}}'
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move,',
'include' => false
],
'partial' => [
'templates' => [
'test' => '{{#testpix}} core, move, blah{{/testpix}}, {{> test2}}',
'test2' => 'some content',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, blah, some content',
'include' => false
],
'partial nested' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{> test2}}{{/testpix}}',
'test2' => 'some content',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, some content',
'include' => false
],
'partial with js' => [
'templates' => [
'test' => '{{#testpix}} core, move, blah{{/testpix}}, {{> test2}}',
'test2' => '{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, blah,',
'include' => true
],
'partial nested with js' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{> test2}}{{/testpix}}',
'test2' => '{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move,',
'include' => false
],
'partial with js from context' => [
'templates' => [
'test' => '{{#testpix}} core, move, blah{{/testpix}}, {{{foo}}}',
'test2' => '{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [
'foo' => '{{> test2}}'
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, blah, {{> test2}}',
'include' => false
],
'partial nested with js from context recursive render' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{foo}}{{/testpix}}',
'test2' => '{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [
'foo' => '{{> test2}}'
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move,',
'include' => false
],
'partial nested with js from context single render' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{foo}}{{/testpix}}',
'test2' => '{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [
'foo' => '{{> test2}}'
],
'helpers' => [
'testpix' => $singlerender
],
'js' => 'some nasty JS',
'expected' => 'core, move, {{> test2}}',
'include' => false
],
'partial double nested with js from context recursive render' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{foo}}{{/testpix}}',
'test2' => '{{#js}} some nasty JS {{/js}}',
],
'torender' => 'test',
'context' => [
'foo' => '{{bar}}',
'bar' => '{{> test2}}'
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move,',
'include' => false
],
'array context depth 1' => [
'templates' => [
'test' => '{{#items}}{{#testpix}} core, move, {{.}}{{/testpix}}{{/items}}'
],
'torender' => 'test',
'context' => [
'items' => [
'legit',
'{{#js}}some nasty JS{{/js}}'
]
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, legit core, move,',
'include' => false
],
'array context depth 2' => [
'templates' => [
'test' => '{{#items}}{{#subitems}}{{#testpix}} core, move, {{.}}{{/testpix}}{{/subitems}}{{/items}}'
],
'torender' => 'test',
'context' => [
'items' => [
[
'subitems' => [
'legit',
'{{#js}}some nasty JS{{/js}}'
]
],
]
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, legit core, move,',
'include' => false
],
'object context depth 1' => [
'templates' => [
'test' => '{{#items}}{{#testpix}} core, move, {{.}}{{/testpix}}{{/items}}'
],
'torender' => 'test',
'context' => (object) [
'items' => [
'legit',
'{{#js}}some nasty JS{{/js}}'
]
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, legit core, move,',
'include' => false
],
'object context depth 2' => [
'templates' => [
'test' => '{{#items}}{{#subitems}}{{#testpix}} core, move, {{.}}{{/testpix}}{{/subitems}}{{/items}}'
],
'torender' => 'test',
'context' => (object) [
'items' => [
(object) [
'subitems' => [
'legit',
'{{#js}}some nasty JS{{/js}}'
]
],
]
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move, legit core, move,',
'include' => false
],
'change delimeters' => [
'templates' => [
'test' => '{{#testpix}} core, move, {{{foo}}}{{/testpix}}'
],
'torender' => 'test',
'context' => [
'foo' => '{{=<% %>=}} <%#js%>some nasty JS,<%/js%>'
],
'helpers' => [
'testpix' => $recursiverender
],
'js' => 'some nasty JS',
'expected' => 'core, move,',
'include' => false
]
];
}
/**
* Test that the mustache_helper_collection class correctly strips
* @dataProvider get_template_testcases()
* @param array $templates The template to add
* @param string $torender The name of the template to render
* @param array $context The template context
* @param array $helpers Mustache helpers to add
* @param string $js The JS string from the template
* @param string $expected The expected output of the string after stripping JS
* @param bool $include If the JS should be added to the page or not
*/
public function test_core_mustache_engine_strips_js_helper(
$templates,
$torender,
$context,
$helpers,
$js,
$expected,
$include
) {
$page = new \moodle_page();
$renderer = $page->get_renderer('core');
// Get the mustache engine from the renderer.
$reflection = new \ReflectionMethod($renderer, 'get_mustache');
$reflection->setAccessible(true);
$engine = $reflection->invoke($renderer);
// Swap the loader out with an array loader so that we can set some
// inline templates for testing.
$loader = new \Mustache_Loader_ArrayLoader([]);
$engine->setLoader($loader);
// Add our test helpers.
$helpercollection = $engine->getHelpers();
foreach ($helpers as $name => $function) {
$helpercollection->add($name, $function);
}
// Add our test template to be rendered.
foreach ($templates as $name => $template) {
$loader->setTemplate($name, $template);
}
// Confirm that the rendered template matches what we expect.
$this->assertEquals($expected, trim($engine->render($torender, $context)));
if ($include) {
// Confirm that the JS was added to the page.
$this->assertStringContainsString($js, $page->requires->get_end_code());
} else {
// Confirm that the JS wasn't added to the page.
$this->assertStringNotContainsString($js, $page->requires->get_end_code());
}
}
}