Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node point counts #10

Closed
connormanning opened this issue Nov 6, 2020 · 2 comments
Closed

Node point counts #10

connormanning opened this issue Nov 6, 2020 · 2 comments

Comments

@connormanning
Copy link
Collaborator

Seeing two issues with the number of points in the output.

  • Zero-point nodes can appear in the output
  • The distribution of point count per node is non-uniform

Some nodes are very small: ignoring the zero-point nodes mentioned, nodes of only 100-500 points are very common. But there are also nodes of almost 2 million points. In particular I'm using the SNCF set but I'd imagine this would be more prominent on dense drone data (will try that next).

For comparison:

  • Entwine - a soft target of 65k points/node. Particularly toward the top levels there may be some poorly distributed small nodes, but in general there's uniformity within a factor of 2 or so.
  • Untwine

I'm not sure of a mechanism with the current sampling method to make things more uniform and I believe there's currently some work in progress on this, but I figured we could use this issue to track the progress of the sampling distributions as that stuff is developed.

@abellgithub
Copy link
Collaborator

You should try again with the latest changes that were pushed this afternoon. You'll still see some large nodes, but it's much better. The end-node size also depends on a guess on uniformity, which may be wrong.

If you can figure out why the current sampling scheme is significantly different from what you get with entwine, that would be great, though I think an adjustment to make the sampling grid smaller would certainly help as well. If you are aiming for spacing at some rate, there's only so much that you can do when the PC is not uniform.

@abellgithub
Copy link
Collaborator

Closing until there are more actionable complaints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants