Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused variables #41

Closed
wonder-sk opened this issue Jan 4, 2021 · 1 comment
Closed

Unused variables #41

wonder-sk opened this issue Jan 4, 2021 · 1 comment

Comments

@wonder-sk
Copy link
Contributor

QGIS builds everything including untwine with -Wunused-variable and -Wunused-parameter compiler flags which raise the following warnings in untwine code:

[5/17] Building CXX object src/providers/pdal/CMakeFiles/untwine.dir/__/__/__/external/untwine/bu/Processor.cpp.o
../external/untwine/bu/Processor.cpp: In member function ‘bool untwine::bu::Processor::acceptable(int, untwine::GridKey)’:
../external/untwine/bu/Processor.cpp:139:32: warning: unused parameter ‘pointId’ [-Wunused-parameter]
  139 | bool Processor::acceptable(int pointId, GridKey key)
      |                            ~~~~^~~~~~~
[11/17] Building CXX object src/providers/pdal/CMakeFiles/untwine.dir/__/__/__/external/untwine/epf/Epf.cpp.o
../external/untwine/epf/Epf.cpp: In member function ‘void untwine::epf::Epf::run(const untwine::Options&, untwine::ProgressWriter&)’:
../external/untwine/epf/Epf.cpp:76:12: warning: unused variable ‘millionPoints’ [-Wunused-variable]
   76 |     double millionPoints = 0;
      |            ^~~~~~~~~~~~~
[12/17] Building CXX object src/providers/pdal/CMakeFiles/untwine.dir/__/__/__/external/untwine/epf/Grid.cpp.o
../external/untwine/epf/Grid.cpp: In member function ‘int untwine::epf::Grid::calcLevel()’:
../external/untwine/epf/Grid.cpp:45:12: warning: unused variable ‘limit’ [-Wunused-variable]
   45 |     double limit = (MaxPointsPerNode / 1000000.0);
      |            ^~~~~
@abellgithub
Copy link
Collaborator

Fixed with 154e7f7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants