Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh-keygen crashes if passphrase is too short. #36

Closed
louisdh opened this issue Apr 27, 2018 · 1 comment
Closed

ssh-keygen crashes if passphrase is too short. #36

louisdh opened this issue Apr 27, 2018 · 1 comment
Labels
fix committed A fix for this issue has been committed. Will soon be closed.

Comments

@louisdh
Copy link
Contributor

louisdh commented Apr 27, 2018

Steps to reproduce (tested in OpenTerm):
• ssh-keygen
• enter "test" as passphrase twice
• crashes on strnvis(fmtbuf, msgbuf, sizeof(fmtbuf) in log.c
holzschu pushed a commit that referenced this issue Apr 28, 2018
@N-Holzschuch
Added vis.c to the sources to resolve a strnvis bug, see issue #36
946f7f5
@holzschu
Copy link
Owner

Well, that's interesting. Using the system strnvis() causes a crash, using strnvis() from vis.c doesn't. Fixed with 946f7f5.

@holzschu holzschu added the fix committed A fix for this issue has been committed. Will soon be closed. label Apr 28, 2018
@holzschu holzschu closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fix committed A fix for this issue has been committed. Will soon be closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@louisdh @holzschu