Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url source image? #20

Open
lakamsani opened this issue Apr 23, 2017 · 2 comments
Open

url source image? #20

lakamsani opened this issue Apr 23, 2017 · 2 comments

Comments

@lakamsani
Copy link

Hi thanks for making this available. Jimp is able to load URL for image sources so I 'm wondering why you made your library require file for source image. I hacked your code and got it to work with URL (by removing some of the file checks) but not good for a pull request. There is a Jimp issue with getExtension but while saving the suffix does not seem to matter and it works.

@honza
Copy link
Owner

honza commented Apr 23, 2017

To be honest, the file requirement is here for historical reasons. I only recently refactored the code to use jimp. I'm certainly happy to support a URL-based source image.

For me personally, the use-case is "here is a directory with a few hundred images, I'd like thumbnails for all of them, please".

Would you be interested in taking this on?

@lakamsani
Copy link
Author

Sure. Once this issue is resolved (related to handling errors with URL images) jimp-dev/jimp#262 I will improve my local hack and send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants