BC-8519 - add room owner role #3473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
NFriedo
reviewed
Dec 12, 2024
NFriedo
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Maybe we should add a test for the case the remove button is not displayed and the disabled checkbox
There was a problem hiding this comment.
I think it would be useful to also have a test for isSelectable: false
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Adding new roles for room-owner and room-admins and adapting the permissions and permission-checks accordingly.
Links to Ticket and related Pull-Requests
BC-8519
hpi-schul-cloud/schulcloud-server#5393
Changes
Data-security
Deployment
New Repos, NPM packages or vendor scripts
Screenshots of UI changes
Checklist before merging