Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the PuppetScripts and GitHelper modules #492

Open
LeonMatthes opened this issue Mar 18, 2019 · 0 comments
Open

Refactor the PuppetScripts and GitHelper modules #492

LeonMatthes opened this issue Mar 18, 2019 · 0 comments
Labels
prio: high This is a high priority issue. refactoring

Comments

@LeonMatthes
Copy link
Contributor

LeonMatthes commented Mar 18, 2019 •
edited
Loading

Description
These modules could both be abstracted into much higher-level functions, which would reduce code-duplication a lot and make the entire module much easier to mock during the tests.

Related Issues
#401, #491
@LeonMatthes LeonMatthes mentioned this issue Mar 18, 2019
Closed
@chrisma chrisma added the prio: medium This is a medium priority issue. label Mar 23, 2019
@chrisma chrisma added prio: high This is a high priority issue. and removed prio: medium This is a medium priority issue. labels Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio: high This is a high priority issue. refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeonMatthes @chrisma