Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Octane (glimmer/modifiers) #131

Closed
DuBistKomisch opened this issue Dec 28, 2019 · 5 comments
Closed

Support Octane (glimmer/modifiers) #131

DuBistKomisch opened this issue Dec 28, 2019 · 5 comments

Comments

@DuBistKomisch
Copy link

DuBistKomisch commented Dec 28, 2019

Thought I'd open this since 3.15/Octane is officially out and recommended, and this is the only addon in my app which gets in the way.

The only real issue as far as I can see is the requirement of the recognizer mixin. I know you can still use extend with an Ember Component as in #127 but this doesn't work with a Glimmer Component.

From my understanding, the appropriate alternative would be a "modifier" which gets added to the element in the template instead. Perhaps I'm missing something to do with Managers though which makes it not that simple.

@knownasilya
Copy link

This would be awesome.

@knownasilya
Copy link

Oh, looks like it's available <div {{recognize-gesture "pan" "tap" "press" }}>. Can close this I think.

@knownasilya
Copy link

knownasilya commented Sep 25, 2020

Looks like jQuery's trigger doesn't trigger the event on element with the modifier:

const $toggle = $('.x-toggle-container');

$toggle.trigger('panright');

Where the element is

<span
  {{recognize-gesture 'pan'}}
  {{on 'panleft' this.handlePanLeft}}
  {{on 'panright' this.handlePanRight}}
>

@eriktrom
Copy link
Member

eriktrom commented Jan 7, 2021

use native custom event, dispatch

jquery is broken for all events, and with pointer events/ui events - even more so...

(i am assuming you have figured this out, probably by asking runspired, so closing, if not, feel free to reopen).

@eriktrom eriktrom closed this as completed Jan 7, 2021
@DuBistKomisch
Copy link
Author

FWIW {{recognize-gesture}} was what I needed, thanks! I'm using this branch to avoid deprecation spam at the moment: #137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants