Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I did not understand tags. I think "cc" should be in "if condition". please clarify the use of each "attr", "sc", "t2i", 'ctcc', 'cc'. #19

Open
LokeshBorawar opened this issue Oct 5, 2024 · 2 comments

Comments

@LokeshBorawar
Copy link

LokeshBorawar commented Oct 5, 2024

In pass_transformer_joint.py file and when training is false at line 409

if ('attr' in self.net_config.test_task_type or 'sc' in self.net_config.test_task_type or 't2i' in self.net_config.test_task_type or 'cross' in self.net_config.test_task_type) and 'ctcc' not in self.net_config.test_task_type:

I think "cc" should be in "if condition", because if self.net_config.test_task_type has not "cc" code will jump to "text_embeds = self.visual_encoder_m(instruction)" but for this instruction should be an image.

please also clarify me the use of each "attr", "sc", "t2i", 'ctcc', 'cc'.

@LokeshBorawar LokeshBorawar changed the title I did not understand tags. I think "ctcc" should be 'cc'. please clarify the use of each "attr", "sc", "t2i", 'ctcc', 'cc'. I did not understand tags. I think "cc" should be in "if condition". please clarify the use of each "attr", "sc", "t2i", 'ctcc', 'cc'. Oct 5, 2024
@DejaYang
Copy link

I do think so. And I think datalise in ltcc dataset is wrong about "white_shirt.jpg", it should be the real clothes image path.

@Marches7
Copy link

Marches7 commented Dec 27, 2024

From my point of view:
ctcc: clothes template clothing changing
cc: clothing changing
t2i: text to instrcution
cross: cross modality (Visible-Infrad)
sc: traditional (preprocessor_sc.py has a variable attr_item='do not change clothes', that strikes me).
attr: Language-instructed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants