Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Consistency: Constructors vs. static methods? #388

Open
sfiruch opened this issue Apr 3, 2023 · 1 comment
Open

API Consistency: Constructors vs. static methods? #388

sfiruch opened this issue Apr 3, 2023 · 1 comment
Assignees
@rohitcbscient @Lukas113 @kenfus
Labels
prio-med Medium priority question Further information is requested

Comments

@sfiruch
Copy link
Member

sfiruch commented Apr 3, 2023

In some cases we run code in constructors...

imager_askap = Imager(
    visibility_askap,
    imaging_npixel=imaging_npixel,
    imaging_cellsize=imaging_cellsize,
)

...in other cases, we only run the actual code in functions:

fh = FileHandle()
fh.clean_up()

interferometer_sim = InterferometerSimulation(channel_bandwidth_hz=1e6)
visibility_askap = interferometer_sim.run_simulation(
    askap_tel, sky, observation_settings
)
@sfiruch sfiruch added question Further information is requested prio-med Medium priority labels Apr 3, 2023
@sfiruch
Copy link
Member Author

sfiruch commented Jul 20, 2023

@Lukas113 @kenfus @rohitcbscient Opinions?

@fschramka fschramka removed their assignment Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohitcbscient rohitcbscient

@Lukas113 Lukas113

@kenfus kenfus

Labels
prio-med Medium priority question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sfiruch @fschramka @rohitcbscient @Lukas113 @kenfus