Skip to content

Commit e51d9f2

Browse files
committed
Feature flags: Handle logged-out users better.
If specific user accounts were allowed to use a feature, logged-out users would cause the feature flag check to fail because UnloggedUser.name exists but raises NotImplementedError. This makes the feature-world return None for user if no user is logged in.
1 parent 5863fb6 commit e51d9f2

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

r2/r2/config/feature/world.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,8 @@ def get_safe(o, key, default=None):
3737
return default
3838

3939
def current_user(self):
40-
return self.get_safe(c, 'user')
40+
if c.user_is_loggedin:
41+
return self.get_safe(c, 'user')
4142

4243
def current_subreddit(self):
4344
site = self.get_safe(c, 'site')

0 commit comments

Comments
 (0)