Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Webpack tests after new 3.4.0 native addon #4031

Closed
1 of 2 tasks
aruniverse opened this issue Aug 5, 2022 · 2 comments
Closed
1 of 2 tasks

Fix Webpack tests after new 3.4.0 native addon #4031

aruniverse opened this issue Aug 5, 2022 · 2 comments
Assignees
@aruniverse
Labels
testing
Milestone
iTwin.js 3.4

Comments

@aruniverse
Copy link
Member

aruniverse commented Aug 5, 2022 •
edited
Loading

Originally posted by @pmconne in #3161 (comment)
@aruniverse aruniverse mentioned this issue Aug 5, 2022
Merged
7 tasks
@aruniverse aruniverse self-assigned this Aug 5, 2022
@aruniverse aruniverse added this to the iTwin.js 3.4 milestone Aug 5, 2022
@aruniverse aruniverse linked a pull request Aug 8, 2022 that will close this issue
[core-webpack-tools] rm .skip and regen snapshot file #4043
Closed
@calebmshafer
Copy link
Member

@aruniverse is this completed now and can be closed?

@aruniverse
Copy link
Member Author

Yea lets close it out, i might create a separate issue for the first item; but sounded like we were going to move away from snapshots so might not be worth the effort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aruniverse aruniverse

Labels
testing
Projects
None yet
Milestone
iTwin.js 3.4
Development

Successfully merging a pull request may close this issue.

[core-webpack-tools] rm .skip and regen snapshot file iTwin/itwinjs-core
2 participants
@aruniverse @calebmshafer