Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate feasibility for Eye-Dome Lighting in non-perspective views #4791

Open
DStradley opened this issue Dec 12, 2022 · 0 comments
Open
Labels

Comments

@DStradley
Copy link
Contributor

Is your feature request related to a problem? Please describe.
In the initial implementation of EDL it was determined that it did not function properly in non-perspective views, so it was disabled there. It did not look promising that it could be made to work, but it is worth further investigation.

Describe the solution you'd like
Ideally, a solution could be found to allow EDL in orthographic views.

Describe alternatives you've considered
Disabling Eye-Dome Lighting in non-perspective views is the current approach.

Additional context
Due to the nature of EDL, we added an auto adjusting term to the Strength setting, which turned out to need 3 different factors to compensate for - cloud size versus current view size, zoom in/out of view, and window size. Without compensation, all of these factors could produce different strength results of the image, making it a lot less usable.
When the same type of factors were applied in ortho views, they did not function well enough. Testing several models showed that some would not even show an EDL effect within the normal range of the DTA controls. Ortho zoom simulates perspective zoom by changing the range of the view frustum (box). So the only things changing are left/right (and top/bottom). We can calculate the size of a pixel in view coordinates, but do not have anything to "normalize" that against for different models. We tried using (far - near), but that did not work well enough. We are not sure that there is a solution for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant