Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new class MultimodalUtterance? #199

Open
NoB0 opened this issue Feb 13, 2023 · 3 comments
Open

Create new class MultimodalUtterance? #199

NoB0 opened this issue Feb 13, 2023 · 3 comments
Labels
improvement Improvement P1 Medium priority question Further information is requested

Comments

@NoB0
Copy link
Collaborator

NoB0 commented Feb 13, 2023

Should we create a new type of instance to handle multimodality (e.g., images, buttons)?

@NoB0 NoB0 added P2 Low priority question Further information is requested labels Feb 13, 2023
@kbalog
Copy link
Contributor

kbalog commented Feb 15, 2023

Yes, that's a good idea.

@NoB0 NoB0 removed the question Further information is requested label Feb 16, 2023
@NoB0 NoB0 changed the title Create new class MultimodalUtterance? Create new class MultimodalUtterance Feb 16, 2023
@NoB0
Copy link
Collaborator Author

NoB0 commented Feb 24, 2023

After discussion, the MultimodalUtterance class is not needed. Instead, we can use metadata at the Utterance level.

@NoB0 NoB0 added P1 Medium priority and removed P2 Low priority labels Feb 24, 2023
@NoB0 NoB0 changed the title Create new class MultimodalUtterance Move the property metadata from AnnotatedUtterance to Utterance Feb 24, 2023
@NoB0 NoB0 added the improvement Improvement label Feb 24, 2023
@kbalog
Copy link
Contributor

kbalog commented Feb 28, 2023

Where did that discussion take place? :)
While functionally equivalent, having a separate class would make it more clear for someone reading the code when a multimodal response is expected.

@NoB0 NoB0 added the question Further information is requested label Mar 17, 2023
@NoB0 NoB0 changed the title Move the property metadata from AnnotatedUtterance to Utterance Create new class MultimodalUtterance? Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement P1 Medium priority question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants