Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/109-Add-documentation-on-server-and-client #115

Merged
merged 3 commits into from
May 7, 2024
Merged

Feature/109-Add-documentation-on-server-and-client #115

merged 3 commits into from
May 7, 2024

Conversation

NoB0
Copy link
Collaborator

@NoB0 NoB0 commented May 6, 2024

Fixes #109

@NoB0 NoB0 requested a review from WerLaj as a code owner May 6, 2024 08:58
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

Unit Test Results

64 tests   64 ✔️  1m 26s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 7e80fdd.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024 •
edited
Loading

Coverage Report •
FileStmtsMissCoverMissing
TOTAL13034994% 
report-only-changed-files is enabled. No files were changed during this commit :)

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Current Branch Main Branch
Coverage Badge Coverage Badge

WerLaj
WerLaj reviewed May 6, 2024
View reviewed changes
docs/source/pkg_client.rst Outdated Show resolved Hide resolved
WerLaj
WerLaj approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@WerLaj WerLaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

docs/source/pkg_client.rst Outdated Show resolved Hide resolved
docs/source/pkg_client.rst Outdated Show resolved Hide resolved
docs/source/pkg_server.rst Outdated Show resolved Hide resolved
@NoB0 NoB0 merged commit 842ce59 into main May 7, 2024
5 checks passed
@NoB0 NoB0 deleted the feature/109-Add-documentation-on-server-and-client branch May 7, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WerLaj WerLaj WerLaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add documentation on server and client
2 participants
@NoB0 @WerLaj